bootstrap: Disallow --exclude test::std
#112297
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, this would use the `Kind` passed to `--exclude` (and not do any filtering at all if no kind was passed). That meant that `x test linkchecker --exclude std` would fail - you had to explicitly say `--exclude test::std`. Change bootstrap to use the top-level Kind instead, which does the right thing automatically. Note that this breaks things like `x test --exclude doc::std`, but I'm not sure why you'd ever want to do that.
|
(rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
jyn514
force-pushed
the
remove-exclude-kind
branch
from
763f843 to
c73c5dd
Compare
|
@bors r+ |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 10, 2023
…iaskrgr Rollup of 5 pull requests Successful merges: - rust-lang#112297 (bootstrap: Disallow `--exclude test::std`) - rust-lang#112298 (Update field-offset and enable unstable_offset_of) - rust-lang#112335 (ci: Upgrade loongarch64-linux-gnu GCC to 13.1.0) - rust-lang#112413 (Adjust span labels for `HIDDEN_GLOB_REEXPORTS`) - rust-lang#112483 (Add deprecation warning to python versions <3.6 in x.py) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the top-level Kind to determine whether Steps are excluded.
Previously, this would use the
Kindpassed to--exclude(and not do any filtering at all if no kind was passed).That meant that
x test linkchecker --exclude stdwould fail - you had to explicitly say--exclude test::std.Change bootstrap to use the top-level Kind instead, which does the right thing automatically.
Note that this breaks things like
x test --exclude doc::std, but I'm not sure why you'd ever want to do that.There's a lot of churn here, but the 1-line change in the first commit is the actual behavior change, the rest is just cleanup.
Fixes #103201. Note that this effectively reverts most of #91965.
cc @pietroalbini