Skip to content

Erase regions even if normalization fails in writeback (in new solver) #112197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 14, 2023
Merged

Erase regions even if normalization fails in writeback (in new solver) #112197

merged 2 commits into from
Jun 14, 2023

Conversation

compiler-errors
Copy link
Member

Or else we ICE during writeback on some programs that error

@rustbot
Copy link
Collaborator

rustbot commented Jun 2, 2023

r? @TaKO8Ki

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 2, 2023
@compiler-errors compiler-errors changed the title Erase regions even if normalization fails in writeback Erase regions even if normalization fails in writeback (in new solver) Jun 2, 2023
lcnr
lcnr reviewed Jun 13, 2023
View reviewed changes
Copy link
Contributor

@lcnr lcnr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me after nit :3

@rust-cloud-vms rust-cloud-vms bot force-pushed the next-solver-erase branch from 832de09 to 7ff79cf Compare June 13, 2023 21:54
@compiler-errors
Copy link
Member Author

r? @lcnr @bors r=lcnr rollup

@bors
Copy link
Collaborator

bors commented Jun 13, 2023

📌 Commit 7ff79cf has been approved by lcnr

It is now in the queue for this repository.

@rustbot rustbot assigned lcnr and unassigned TaKO8Ki Jun 13, 2023
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 13, 2023
@matthiaskrgr matthiaskrgr mentioned this pull request Jun 14, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 14, 2023
@bors
Auto merge of rust-lang#112609 - matthiaskrgr:rollup-er6weld, r=matth…
57c215b 
…iaskrgr

Rollup of 5 pull requests

Successful merges:

 - rust-lang#112197 (Erase regions even if normalization fails in writeback (in new solver))
 - rust-lang#112495 (fix(resolve): update shadowed_glob more precision)
 - rust-lang#112520 (Fix the overflow issue for transmute_generic_consts)
 - rust-lang#112571 (rustdoc-search: search never type with `!`)
 - rust-lang#112581 ([rustdoc] Fix URL encoding of % sign)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 6fc50da into rust-lang:master Jun 14, 2023
@rustbot rustbot added this to the 1.72.0 milestone Jun 14, 2023
@compiler-errors compiler-errors deleted the next-solver-erase branch August 11, 2023 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lcnr lcnr lcnr left review comments

Assignees

@lcnr lcnr

Labels
A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.72.0
Development

Successfully merging this pull request may close these issues.
5 participants
@compiler-errors @rustbot @bors @lcnr @TaKO8Ki