Always capture slice when pattern requires checking the length #111831
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @eholk (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
tests/ui/closures/2229_closure_analysis/match/patterns-capture-analysis.stderr
Outdated
Show resolved
Hide resolved
rust-cloud-vms
bot
force-pushed
the
capture-slice-pat
branch
from
981cdea to
f5ae107
Compare
est31
reviewed
May 22, 2023
rust-cloud-vms
bot
force-pushed
the
capture-slice-pat
branch
from
f5ae107 to
403dce4
Compare
|
Nice. I didn't have time during weekend. |
cjgillot
reviewed
May 25, 2023
tests/ui/closures/2229_closure_analysis/match/patterns-capture-analysis.rs
Outdated
Show resolved
Hide resolved
rust-cloud-vms
bot
force-pushed
the
capture-slice-pat
branch
from
403dce4 to
e6bab70
Compare
cjgillot
reviewed
May 25, 2023
rust-cloud-vms
bot
force-pushed
the
capture-slice-pat
branch
from
e6bab70 to
ace794c
Compare
|
Thanks! |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
May 25, 2023
…illot Always capture slice when pattern requires checking the length Fixes rust-lang#111751 cc `@zirconium-n,` I see you were assigned to this but I've fixed some similar issues in the past and had an idea on how to investigate this.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 25, 2023
…mpiler-errors Rollup of 7 pull requests Successful merges: - rust-lang#107522 (Add Median of Medians fallback to introselect) - rust-lang#111152 (update `pulldown-cmark` to `0.9.3`) - rust-lang#111757 (Consider lint check attributes on match arms) - rust-lang#111831 (Always capture slice when pattern requires checking the length) - rust-lang#111929 (Don't print newlines in APITs) - rust-lang#111945 (Migrate GUI colors test to original CSS color format) - rust-lang#111950 (Remove ExpnKind::Inlined.) r? `@ghost` `@rustbot` modify labels: rollup
BoxyUwU
reviewed
Jun 14, 2023
| if matches!((lhs, wild, rhs), (&[], Some(_), &[])) | ||
| // Arrays have a statically known size, so | ||
| // there is no need to read their length | ||
| || discr_place.place.base_ty.is_array() |
There was a problem hiding this comment.
Does this cause us to emit reads when matching on &[T; N]? If so that might be the cause of #112607
There was a problem hiding this comment.
It doesn't matter if this is the cause, gce is free to be broken
There was a problem hiding this comment.
It does yes. I'll fix it now, since this is definitely incorrect right now
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 18, 2023
…gillot Don't capture `&[T; N]` when contents isn't read Fixes the check in rust-lang#111831 Fixes rust-lang#112607, although I decided to test the root cause rather than including the example in the issue as a test. cc `@BoxyUwU`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #111751
cc @zirconium-n, I see you were assigned to this but I've fixed some similar issues in the past and had an idea on how to investigate this.