Skip to content

Switch to EarlyBinder for thir_abstract_const query #111410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 10, 2023
Merged

Switch to EarlyBinder for thir_abstract_const query #111410

merged 1 commit into from
May 10, 2023

Conversation

kylematsuda
Copy link
Contributor

Part of the work to finish #105779.

This PR adds EarlyBinder to the return type of the thir_abstract_const query and removes bound_abstract_const.

r? @compiler-errors

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels May 9, 2023
@rustbot
Copy link
Collaborator

rustbot commented May 9, 2023

Some changes occurred in abstract_const.rs

cc @BoxyUwU

Some changes occurred in rustc_ty_utils::consts.rs

cc @BoxyUwU

@BoxyUwU
Copy link
Member

BoxyUwU commented May 9, 2023

r? @BoxyUwU @bors r+ rollup

@bors
Copy link
Collaborator

bors commented May 9, 2023

📌 Commit 26dc139 has been approved by BoxyUwU

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 9, 2023
@matthiaskrgr matthiaskrgr mentioned this pull request May 10, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request May 10, 2023
@bors
Auto merge of rust-lang#111414 - matthiaskrgr:rollup-q0qoc47, r=matth…
25444e5 
…iaskrgr

Rollup of 6 pull requests

Successful merges:

 - rust-lang#110673 (Make alias bounds sound in the new solver (take 2))
 - rust-lang#110747 (Encode types in SMIR)
 - rust-lang#111095 (Correctly handle associated items of a trait inside a `#[doc(hidden)]` item)
 - rust-lang#111381 (Keep encoding attributes for closures)
 - rust-lang#111408 (Fix incorrect implication of transmuting slices)
 - rust-lang#111410 (Switch to `EarlyBinder` for `thir_abstract_const` query)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 70d5bf7 into rust-lang:master May 10, 2023
@rustbot rustbot added this to the 1.71.0 milestone May 10, 2023
@kylematsuda kylematsuda deleted the earlybinder-abstract-const branch May 10, 2023 15:16
@kylematsuda kylematsuda mentioned this pull request May 10, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@BoxyUwU BoxyUwU

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.71.0
Development

Successfully merging this pull request may close these issues.
5 participants
@kylematsuda @rustbot @BoxyUwU @bors @compiler-errors