Skip to content

Conversation

albertlarsan68
Copy link
Member

Fixes #111046.

Wrap all of x.py in if __name__ == '__main__': to avoid problems with multiprocessing
Make the pool sizing better

@rustbot
Copy link
Collaborator

rustbot commented May 1, 2023

r? @ozkanonur

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels May 1, 2023
@albertlarsan68 albertlarsan68 mentioned this pull request May 1, 2023
@albertlarsan68 albertlarsan68 force-pushed the fix-multiprocessing-x-py branch from 2b13a32 to ee1446a Compare May 1, 2023 16:16
@jyn514
Copy link
Member

jyn514 commented May 1, 2023

@bors r+ rollup p=20 (fixes x on Windows)

@bors
Copy link
Collaborator

bors commented May 1, 2023

📌 Commit ee1446af10e4dfaa8718e5fae468452ecfbc8af6 has been approved by jyn514

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 1, 2023
@rust-log-analyzer

This comment has been minimized.

@jyn514
Copy link
Member

jyn514 commented May 1, 2023

😩

@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 1, 2023
Wrap all of x.py in `if __name__ == '__main__':` to avoid problems with `multiprocessing`
Make the pool sizing better
@albertlarsan68 albertlarsan68 force-pushed the fix-multiprocessing-x-py branch from ee1446a to 3011949 Compare May 1, 2023 16:20
@albertlarsan68
Copy link
Member Author

@bors r=jyn514

@bors
Copy link
Collaborator

bors commented May 1, 2023

📌 Commit 3011949 has been approved by jyn514

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 1, 2023
@bors
Copy link
Collaborator

bors commented May 1, 2023

⌛ Testing commit 3011949 with merge dbba594...

@bors
Copy link
Collaborator

bors commented May 1, 2023

☀️ Test successful - checks-actions
Approved by: jyn514
Pushing dbba594 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label May 1, 2023
@bors bors merged commit dbba594 into rust-lang:master May 1, 2023
@rustbot rustbot added this to the 1.71.0 milestone May 1, 2023
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (dbba594): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
2.1% [2.1%, 2.1%] 1
Regressions ❌
(secondary)
0.9% [0.9%, 1.0%] 2
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 2.1% [2.1%, 2.1%] 1

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 656.548s -> 656.457s (-0.01%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed to run x
7 participants