Rollup of 6 pull requests #110752

matthiaskrgr · 2023-04-24T05:53:26Z

Successful merges:

Suggest using integration tests for test crate using own proc-macro #110255 (Suggest using integration tests for test crate using own proc-macro)
Remove find_map_relevant_impl #110514 (Remove find_map_relevant_impl)
Don't create projection ty for const projection #110566 (Don't create projection ty for const projection)
Group some sections of our logs in github actions #110637 (Group some sections of our logs in github actions)
Add intrinsics::transmute_unchecked #110706 (Add intrinsics::transmute_unchecked)
Normalize types and consts in MIR opts. #110714 (Normalize types and consts in MIR opts.)

Failed merges:

r? @ghost
@rustbot modify labels: rollup

This takes a whole 3 lines in `compiler/` since it lowers to `CastKind::Transmute` in MIR *exactly* the same as the existing `intrinsics::transmute` does, it just doesn't have the fancy checking in `hir_typeck`. Added to enable experimenting with the request in <rust-lang#106281 (comment)> and because the portable-simd folks might be interested for dependently-sized array-vector conversions. It also simplifies a couple places in `core`.

…jackh726 Suggest using integration tests for test crate using own proc-macro cc rust-lang#110247

…levant_impl, r=b-naber Remove `find_map_relevant_impl` Fixes rust-lang#108895

…m, r=cjgillot,BoxyUwU Don't create projection ty for const projection Fixes rust-lang#110549

Group some sections of our logs in github actions This makes logs a little bit more readable as you can now collapse all the parts that don't interest you (and they get collapsed automatically) Obviously there's a lot more sites where we can/need to do this, too, but this is already helpful imo r? ```@jyn514```

…i-obk Add `intrinsics::transmute_unchecked` This takes a whole 3 lines in `compiler/` since it lowers to `CastKind::Transmute` in MIR *exactly* the same as the existing `intrinsics::transmute` does, it just doesn't have the fancy checking in `hir_typeck`. Added to enable experimenting with the request in <rust-lang#106281 (comment)> and because the portable-simd folks might be interested for dependently-sized array-vector conversions. It also simplifies a couple places in `core`. See also rust-lang#108442 (comment), where `CastKind::Transmute` was added having exactly these semantics before the lang meeting (which I wasn't in) independently expressed interest.

Normalize types and consts in MIR opts. Some passes were using a non-RevealAll param_env, which is needlessly restrictive in mir-opts. As a drive-by, we normalize all constants, since just normalizing their types is not enough.

matthiaskrgr · 2023-04-24T05:54:03Z

@bors r+ rollup=never p=6

bors · 2023-04-24T05:54:05Z

📌 Commit 2ce9b57 has been approved by matthiaskrgr

It is now in the queue for this repository.

bors · 2023-04-24T10:03:15Z

⌛ Testing commit 2ce9b57 with merge 64bcb32...

bors · 2023-04-24T12:07:05Z

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing 64bcb32 to master...

bors · 2023-04-24T12:07:06Z

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing 64bcb32 to master...

rust-timer · 2023-04-24T12:07:12Z

📌 Perf builds for each rolled up PR:

PR#	Perf Build Sha

previous master: 64bcb32651

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

rust-timer · 2023-04-24T12:08:50Z

📌 Perf builds for each rolled up PR:

PR#	Perf Build Sha
#110714	5155cf6c8de4f22bac9952b3a1fd5bf5f5e59625
#110706	e99ae471c8dc6ac25c35ffdf3d436fc376c9f74d
#110637	f863ea173386b92332f1c0efcbc181961815b939
#110566	fc34389c6e44beaa2a829425ffc9190c13e21b4c
#110514	905928844aa26e8cd5d643986835ecea988801b8
#110255	4c25b09f1994f4682d7481e57aff838c74a3fbc8

previous master: f65615f02d

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

rust-timer · 2023-04-24T13:25:49Z

Finished benchmarking commit (64bcb32): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-2.7%	[-2.9%, -2.5%]	2
Improvements ✅ (secondary)	-4.7%	[-7.6%, -0.3%]	8
All ❌✅ (primary)	-2.7%	[-2.9%, -2.5%]	2

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	2.1%	[2.1%, 2.1%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-5.3%	[-5.3%, -5.3%]	1
All ❌✅ (primary)	2.1%	[2.1%, 2.1%]	1

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-3.8%	[-3.9%, -3.7%]	2
All ❌✅ (primary)	-	-	0

clubby789 and others added 13 commits April 17, 2023 13:01

Suggest using integration tests for proc-macros

f7581d8

Remove find_map_relevant_impl

1467877

Group entire build steps in the gha logs

95e8b6a

Also reveal constants before MIR opts.

7efcf67

Use param_env_reveal_all_normalized in MIR opts.

4fe5136

Don't create projection ty for const projection

cde5bca

Rollup merge of rust-lang#110255 - clubby789:proc-macro-test-help, r=…

0f27161

…jackh726 Suggest using integration tests for test crate using own proc-macro cc rust-lang#110247

Rollup merge of rust-lang#110514 - compiler-errors:remove-find_map_re…

d60c64a

…levant_impl, r=b-naber Remove `find_map_relevant_impl` Fixes rust-lang#108895

Rollup merge of rust-lang#110566 - compiler-errors:bad-projection-ter…

8aab707

…m, r=cjgillot,BoxyUwU Don't create projection ty for const projection Fixes rust-lang#110549

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 24, 2023

bors added the merged-by-bors This PR was explicitly merged by bors. label Apr 24, 2023

bors merged commit 64bcb32 into rust-lang:master Apr 24, 2023

rustbot added this to the 1.71.0 milestone Apr 24, 2023

matthiaskrgr deleted the rollup-959s77u branch March 16, 2024 18:18

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Rollup of 6 pull requests #110752

Rollup of 6 pull requests #110752

Uh oh!

matthiaskrgr commented Apr 24, 2023

Uh oh!

matthiaskrgr commented Apr 24, 2023

Uh oh!

bors commented Apr 24, 2023

Uh oh!

bors commented Apr 24, 2023

Uh oh!

bors commented Apr 24, 2023

Uh oh!

bors commented Apr 24, 2023

Uh oh!

rust-timer commented Apr 24, 2023

Uh oh!

rust-timer commented Apr 24, 2023

Uh oh!

rust-timer commented Apr 24, 2023

Uh oh!

Uh oh!

Rollup of 6 pull requests #110752

Rollup of 6 pull requests #110752

Uh oh!

Conversation

matthiaskrgr commented Apr 24, 2023

Uh oh!

matthiaskrgr commented Apr 24, 2023

Uh oh!

bors commented Apr 24, 2023

Uh oh!

bors commented Apr 24, 2023

Uh oh!

bors commented Apr 24, 2023

Uh oh!

bors commented Apr 24, 2023

Uh oh!

rust-timer commented Apr 24, 2023

Uh oh!

rust-timer commented Apr 24, 2023

Uh oh!

rust-timer commented Apr 24, 2023

Overall result: ✅ improvements - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Uh oh!

Uh oh!