Skip to content

rustdoc: avoid including line numbers in Google SERP snippets #109977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 6, 2023
Merged

rustdoc: avoid including line numbers in Google SERP snippets #109977

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions src/librustdoc/html/static/css/rustdoc.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -348,7 +348,7 @@ pre.item-decl {
.source .content pre {
padding: 20px;
}
.rustdoc.source .example-wrap > pre.src-line-numbers {
.rustdoc.source .example-wrap pre.src-line-numbers {
padding: 20px 0 20px 4px;
}

Expand Down Expand Up @@ -533,17 +533,17 @@ ul.block, .block li {
margin-bottom: 0px;
}

.rustdoc .example-wrap > pre {
.rustdoc .example-wrap pre {
margin: 0;
flex-grow: 1;
}

.rustdoc:not(.source) .example-wrap > pre {
.rustdoc:not(.source) .example-wrap pre {
overflow: auto hidden;
}

.rustdoc .example-wrap > pre.example-line-numbers,
.rustdoc .example-wrap > pre.src-line-numbers {
.rustdoc .example-wrap pre.example-line-numbers,
.rustdoc .example-wrap pre.src-line-numbers {
flex-grow: 0;
min-width: fit-content; /* prevent collapsing into nothing in truncated scraped examples */
overflow: initial;
Expand All @@ -554,7 +554,7 @@ ul.block, .block li {
color: var(--src-line-numbers-span-color);
}

.rustdoc .example-wrap > pre.src-line-numbers {
.rustdoc .example-wrap pre.src-line-numbers {
padding: 14px 0;
}
.src-line-numbers a, .src-line-numbers span {
Expand Down Expand Up @@ -702,7 +702,7 @@ h2.small-section-header > .anchor {
}

.main-heading a:hover,
.example-wrap > .rust a:hover,
.example-wrap .rust a:hover,
.all-items a:hover,
.docblock a:not(.test-arrow):not(.scrape-help):not(.tooltip):hover,
.docblock-short a:not(.test-arrow):not(.scrape-help):not(.tooltip):hover,
Expand Down
6 changes: 4 additions & 2 deletions src/librustdoc/html/templates/source.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,15 @@
<div class="example-wrap"> {# #}
<pre class="src-line-numbers">
{# https://developers.google.com/search/docs/crawling-indexing/robots-meta-tag#data-nosnippet-attr
Do not show "1 2 3 4 5 ..." in web search results. #}
<div data-nosnippet><pre class="src-line-numbers">
{% for line in lines.clone() %}
{% if embedded %}
<span>{{line|safe}}</span>
{%~ else %}
<a href="#{{line|safe}}" id="{{line|safe}}">{{line|safe}}</a>
{%~ endif %}
{% endfor %}
</pre> {# #}
</pre></div> {# #}
<pre class="rust"> {# #}
<code>
{% if needs_expansion %}
Expand Down