Sync rustc_codegen_cranelift #109169

bjorn3 · 2023-03-15T14:51:55Z

Bunch of bug fixes this time. Also an update to Cranelift 0.93 which adds a brand new optimization pass which cg_clif exposes when using --release. And various improvements to cg_clif's test suite, making it faster to run. And finally two small perf improvements.

r? @ghost

@rustbot label +A-codegen +A-cranelift +T-compiler

Use rint intrinsic instead of roundeven to impement `round_ties_even`. They do the same thing when rounding mode is default, which Rust assumes. And `rint` has better platform support. Keeps `roundeven` around in `core::intrinsics`, it's doing no harm there.

…clif-2023-02-09

This slightly improves performance on systems with many cores and barely affects systems with few cores. My laptop (2 core + HT): Before: Benchmark 2: RUSTC=rustc /home/bjorn/Projects/cg_clif2/./dist/cargo-clif build --manifest-path /home/bjorn/Projects/cg_clif2/./download/simple-raytracer/Cargo.toml --target-dir /home/bjorn/Projects/cg_clif2/./build/simple_raytracer Time (mean ± σ): 12.042 s ± 0.313 s [User: 29.434 s, System: 4.720 s] Range (min … max): 11.670 s … 12.795 s 10 runs After: Benchmark 2: RUSTC=rustc /home/bjorn/Projects/cg_clif2/./dist/cargo-clif build --manifest-path /home/bjorn/Projects/cg_clif2/./download/simple-raytracer/Cargo.toml --target-dir /home/bjorn/Projects/cg_clif2/./build/simple_raytracer Time (mean ± σ): 12.037 s ± 0.384 s [User: 29.960 s, System: 4.722 s] Range (min … max): 11.673 s … 12.769 s 10 runs Dev desktop (32 cores) Before: Benchmark 2: RUSTC=rustc /home/gh-bjorn3/cg_clif/./dist/cargo-clif build --manifest-path /home/gh-bjorn3/cg_clif/./download/simple-raytracer/Cargo.toml --target-dir /home/gh-bjorn3/cg_clif/./build/simple_raytracer Time (mean ± σ): 10.425 s ± 0.104 s [User: 25.877 s, System: 5.513 s] Range (min … max): 10.267 s … 10.640 s 10 runs After: Benchmark 2: RUSTC=rustc /home/gh-bjorn3/cg_clif/./dist/cargo-clif build --manifest-path /home/gh-bjorn3/cg_clif/./download/simple-raytracer/Cargo.toml --target-dir /home/gh-bjorn3/cg_clif/./build/simple_raytracer Time (mean ± σ): 10.212 s ± 0.100 s [User: 25.918 s, System: 5.555 s] Range (min … max): 10.079 s … 10.362 s 10 runs

clippy::perf fixes

clippy::complexity fixes

Don't ICE in `might_permit_raw_init` if reference is polymorphic Emitting optimized MIR for a polymorphic function may require computing layout of a type that isn't (yet) known. This happens in the instcombine pass, for example. Let's fail gracefully in that condition. cc `@saethlin` fixes rust-lang#107999

There are several `mk_foo`/`intern_foo` pairs, where the former takes an iterator and the latter takes a slice. (This naming convention is bad, but that's a fix for another PR.) This commit changes several `mk_foo` occurrences into `intern_foo`, avoiding the need for some `.iter()`/`.into_iter()` calls. Affected cases: - mk_type_list - mk_tup - mk_substs - mk_const_list

Fixes rust-lang#1294

Add `--no-undefined-version` link flag and fix associated breakage LLVM upstream sets `--no-undefined-version` by default in lld: https://reviews.llvm.org/D135402. Due to a bug in how version scripts are generated, this breaks the `dylib` output type for most crates. See rust-lang#105967 (comment) for details. This PR adds the flag to gcc flavor linkers in anticipation of this LLVM change rolling in, and patches `rustc` to not attempt to export `__rust_*` allocator symbols when they weren't generated. Fixes rust-lang#105967

Add more license annotations This PR updates the `.reuse/dep5` file to include more accurate licensing data for everything in the repository (*excluding* submodules and dependencies). Some decisions were made in this PR: * The standard copyright attribution for files maintained by us is "The Rust Project Developers (see https://thanks.rust-lang.org)", to avoid having to maintain an in-tree `AUTHORS` file. * For files that have specific licensing terms, we added the terms to the `.reuse/dep5` rather than adding SPDX comments in the files themselves. * REUSE picks up any comment/text line with `Copyright` on it, so I had to sprinkle around `REUSE-IgnoreStart` and `REUSE-IgnoreEnd` comments. The rendered `COPYRIGHT` file is available at https://gist.github.com/pietroalbini/efb81103f69596d39758114f3f6a8688. r? `@pnkfelix`

…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#105798 (Relax ordering rules for `asm!` operands) - rust-lang#105962 (Stabilize path_as_mut_os_str) - rust-lang#106085 (use problem matchers for tidy CI) - rust-lang#107711 (Stabilize movbe target feature) - rust-lang#108017 (Add `--no-undefined-version` link flag and fix associated breakage) - rust-lang#108891 (Remove an extraneous include) - rust-lang#108902 (no more do while :<) - rust-lang#108912 (Document tool lints) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup

This patched has been necessary for subtree syncs from the start, but previously it was necessary to locally install tqc's patched git version, which hasn't been updated for quite a while. I made a small change to allow downloading it as script without requiring an entire git installation for the patched version.

…clif-2023-03-15

bjorn3 · 2023-03-15T14:59:44Z

@bors r+ p=1 subtree sync

bors · 2023-03-15T14:59:47Z

📌 Commit fce629d has been approved by bjorn3

It is now in the queue for this repository.

bors · 2023-03-15T18:30:08Z

⌛ Testing commit fce629d with merge ab65486...

bors · 2023-03-15T21:17:09Z

☀️ Test successful - checks-actions
Approved by: bjorn3
Pushing ab65486 to master...

rust-timer · 2023-03-17T06:19:41Z

Finished benchmarking commit (ab65486): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	1.0%	[0.6%, 1.3%]	8
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	2.1%	[1.8%, 2.3%]	2
Regressions ❌ (secondary)	2.2%	[2.2%, 2.2%]	1
Improvements ✅ (primary)	-2.6%	[-2.6%, -2.6%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.5%	[-2.6%, 2.3%]	3

Cycles

This benchmark run did not return any relevant results for this metric.

lqd · 2023-03-17T10:07:57Z

That tt-muncher regression looks like noise.

Jules-Bertholet and others added 30 commits December 11, 2022 01:20

Add round_ties_even to f32 and f64

36cd4fa

Merge commit '7d53619064ab7045c383644cb445052d2a3d46db' into sync_cg_…

56951e4

…clif-2023-02-09

Merge branch 'sync_from_rust'

bbf3900

Avoid spurious visible_parent_map query invocation

bdb0665

Remove a couple of duplicate layout_of and monomorphize calls

7870b29

clippy::perf fixes

1a072c5

Merge pull request rust-lang#1355 from matthiaskrgr/clippy_perf

291cadb

clippy::perf fixes

clippy::complexity fixes

0b62b64

Merge pull request rust-lang#1356 from matthiaskrgr/clippy_compl

efd33c5

clippy::complexity fixes

Alias folding/visiting traits instead of re-export

c95eca2

s/eval_usize/eval_target_usize/ for clarity

14bc2e6

Sync from rust e9ab787

72c6655

Rustup to rustc 1.69.0-nightly (065852d 2023-02-13)

478bc5b

Fix non-dynamic indexing into vector types

5bf5153

Make permit_uninit/zero_init fallible

c756108

if $c:expr { Some($r:expr) } else { None } =>> $c.then(|| $r)

f58bd0e

Sync from rust 0416b1a

afcdf57

Rustup to rustc 1.69.0-nightly (0416b1a 2023-02-14)

9491031

Rustup to rustc 1.69.0-nightly (2d14db3 2023-02-15)

8ed6baa

Sync from rust 9a7cc6c

8e5a9bb

Rustup to rustc 1.69.0-nightly (9a7cc6c 2023-02-16)

3c5d5ba

Support updating to specific dates in rustup.sh

718574a

Fixes rust-lang#1294

Remove easy_call

cdf4f42

Use new abi for 128bit int to float cast intrinsics on Windows

e58bb2a

Add fixme

7bd3b77

Move windows i128 argument by-ref handling to lib_call

ede7cde

bjorn3 and others added 13 commits March 10, 2023 14:12

Rustup to rustc 1.70.0-nightly (39f2657 2023-03-09)

e781db8

Fix rustc test suite

0b9e8c6

Remove uses of box_syntax in rustc and tools

2c122a8

Sync from rust 7b4f489

02af3e3

Rustup to rustc 1.70.0-nightly (7b4f489 2023-03-12)

db6fb61

Introduce Box::new in mini_core

6f60071

Sync from rust 1716932

fed9534

Rustup to rustc 1.70.0-nightly (1716932 2023-03-14)

dec0daa

Merge commit 'dec0daa8f6d0a0e1c702f169abb6bf3eee198c67' into sync_cg_…

fce629d

…clif-2023-03-15

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 15, 2023

bors added the merged-by-bors This PR was explicitly merged by bors. label Mar 15, 2023

bors merged commit ab65486 into rust-lang:master Mar 15, 2023

rustbot added this to the 1.70.0 milestone Mar 15, 2023

bjorn3 deleted the sync_cg_clif-2023-03-15 branch March 15, 2023 21:27

gurry mentioned this pull request Dec 21, 2023

arithmetic_overflow lint not triggered for overflowing shifts in promoteds #117949

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Sync rustc_codegen_cranelift #109169

Sync rustc_codegen_cranelift #109169

Uh oh!

bjorn3 commented Mar 15, 2023

Uh oh!

bjorn3 commented Mar 15, 2023

Uh oh!

bors commented Mar 15, 2023

Uh oh!

bors commented Mar 15, 2023

Uh oh!

bors commented Mar 15, 2023

Uh oh!

rust-timer commented Mar 17, 2023

Uh oh!

lqd commented Mar 17, 2023

Uh oh!

Uh oh!

Sync rustc_codegen_cranelift #109169

Sync rustc_codegen_cranelift #109169

Uh oh!

Conversation

bjorn3 commented Mar 15, 2023

Uh oh!

bjorn3 commented Mar 15, 2023

Uh oh!

bors commented Mar 15, 2023

Uh oh!

bors commented Mar 15, 2023

Uh oh!

bors commented Mar 15, 2023

Uh oh!

rust-timer commented Mar 17, 2023

Overall result: ❌ regressions - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Uh oh!

lqd commented Mar 17, 2023

Uh oh!

Uh oh!