Add eslint check for rustdoc-gui tester #109052
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
A-testsuite
notriddle
reviewed
Mar 12, 2023
| "node": true, | ||
| "es6": true | ||
| }, | ||
| "extends": "eslint:recommended", |
There was a problem hiding this comment.
Is there a way to make this file inherit from rustdoc-js? This is a lot of duplicate config, and I'd like to prevent them from drifting apart.
There was a problem hiding this comment.
I originally wanted to make this one a link to the other but apparently, git doesn't handle that very nicely... I could have one .eslintrc.js file but not sure where to put it...
There was a problem hiding this comment.
It's fine. I was just curious.
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 12, 2023
…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#108651 (Forbid the use of `#[target_feature]` on `main`) - rust-lang#109009 (rustdoc: use restricted Damerau-Levenshtein distance for search) - rust-lang#109026 (Introduce `Rc::into_inner`, as a parallel to `Arc::into_inner`) - rust-lang#109029 (Gate usages of `dyn*` and const closures in macros) - rust-lang#109031 (Rename `config.toml.example` to `config.example.toml`) - rust-lang#109032 (Use `TyCtxt::trait_solver_next` in some places) - rust-lang#109047 (typo) - rust-lang#109052 (Add eslint check for rustdoc-gui tester) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @notriddle