Add note when matching token with nonterminal #108711
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
fmease
reviewed
Mar 3, 2023
rust-cloud-vms
bot
force-pushed
the
nt-note
branch
from
1f7bc50 to
04adb93
Compare
petrochenkov
reviewed
Mar 6, 2023
petrochenkov
added
S-waiting-on-author
rust-cloud-vms
bot
force-pushed
the
nt-note
branch
from
04adb93 to
b3ec31a
Compare
|
@rustbot ready |
rustbot
added
S-waiting-on-review
petrochenkov
reviewed
Mar 9, 2023
|
r=me after addressing nits |
rustbot
added
S-waiting-on-author
The current error message is _really_ confusing.
rust-cloud-vms
bot
force-pushed
the
nt-note
branch
from
b3ec31a to
3dee463
Compare
|
@bors r=petrochenkov |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Mar 11, 2023
Add note when matching token with nonterminal The current error message is _really_ confusing. The implementation is slightly hacky, but not that much more hacky than all this nonterminal stuff.. r? `@petrochenkov`
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 11, 2023
…iaskrgr Rollup of 9 pull requests Successful merges: - rust-lang#106276 (Fix `vec_deque::Drain` FIXME) - rust-lang#107629 (rustdoc: sort deprecated items lower in search) - rust-lang#108711 (Add note when matching token with nonterminal) - rust-lang#108757 (rustdoc: Migrate `document_item_info` to Askama) - rust-lang#108784 (rustdoc: Migrate sidebar rendering to Askama) - rust-lang#108927 (Move __thread_local_inner to sys) - rust-lang#108949 (Honor current target when checking conditional compilation values) - rust-lang#108950 (Directly construct Inherited in typeck.) - rust-lang#108988 (rustdoc: Don't crash on `crate` references in blocks) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current error message is really confusing. The implementation is slightly hacky, but not that much more hacky than all this nonterminal stuff..
r? @petrochenkov