Skip to content

Allow building serde and serde_derive in parallel #108308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 27, 2023
Merged

Allow building serde and serde_derive in parallel #108308

merged 1 commit into from
Feb 27, 2023

Conversation

@bjorn3
Copy link
Member

@bjorn3 bjorn3 commented Feb 21, 2023

This reduces build time of bootstrap by ~6s

@rustbot
Copy link
Collaborator

rustbot commented Feb 21, 2023

r? @albertlarsan68

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Feb 21, 2023
@albertlarsan68
Copy link
Member

Output of this hyperfine incantation:

$ hyperfine -L commit 87745f71312bb8459c1ab728c3ae76f8d0f50801,bda32a4023b1d3f96e56e1b2fc7510324f430316 -s "git checkout --force {commit} && git submodule update" -p "x clean" -w 1 -m 3 -n "Commit {commit}: `x help`" "x help || true"

Benchmark 1: Commit 87745f71312bb8459c1ab728c3ae76f8d0f50801: `x help`
  Time (mean ± σ):     34.434 s ±  0.189 s    [User: 168.235 s, System: 11.999 s]
  Range (min … max):   34.243 s … 34.620 s    3 runs

Benchmark 2: Commit bda32a4023b1d3f96e56e1b2fc7510324f430316: `x help`
  Time (mean ± σ):     36.572 s ±  0.236 s    [User: 163.442 s, System: 11.890 s]
  Range (min … max):   36.343 s … 36.814 s    3 runs

Summary
  'Commit 87745f71312bb8459c1ab728c3ae76f8d0f50801: `x help`' ran
    1.06 ± 0.01 times faster than 'Commit bda32a4023b1d3f96e56e1b2fc7510324f430316: `x help`'

This means that your PR is a (slight) improvement.

Thanks for the PR!
@bors r+

@bors
Copy link
Collaborator

bors commented Feb 26, 2023

📌 Commit 87745f71312bb8459c1ab728c3ae76f8d0f50801 has been approved by albertlarsan68

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 26, 2023
klensy
klensy reviewed Feb 26, 2023
View reviewed changes
@bjorn3
Copy link
Member Author

bjorn3 commented Feb 26, 2023

@bors r-

Will add the comment @klensy suggested tomorrow.

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 26, 2023
@bjorn3
Allow building serde and serde_derive in parallel
fdbc3c2 
This reduces build time of bootstrap by ~6s
@bjorn3 bjorn3 force-pushed the faster_bootstrap_build branch from 87745f7 to fdbc3c2 Compare February 27, 2023 11:19
@bjorn3
Copy link
Member Author

bjorn3 commented Feb 27, 2023

Added comment.

@bjorn3
Copy link
Member Author

bjorn3 commented Feb 27, 2023

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 27, 2023
@albertlarsan68
Copy link
Member

Thanks for the PR!
@bors r+

@bors
Copy link
Collaborator

bors commented Feb 27, 2023

📌 Commit fdbc3c2 has been approved by albertlarsan68

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 27, 2023
@matthiaskrgr matthiaskrgr mentioned this pull request Feb 27, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 27, 2023
@bors
Auto merge of rust-lang#108538 - matthiaskrgr:rollup-vw6h5ea, r=matth…
7281249 
…iaskrgr

Rollup of 8 pull requests

Successful merges:

 - rust-lang#104265 (Move IpAddr, SocketAddr and V4+V6 related types to `core`)
 - rust-lang#107110 ([stdio][windows] Use MBTWC and WCTMB)
 - rust-lang#108308 (Allow building serde and serde_derive in parallel)
 - rust-lang#108363 (Move the unused extern crate check back to the resolver.)
 - rust-lang#108519 (Bages for easy access links to Rust community)
 - rust-lang#108522 (Commit some new solver tests)
 - rust-lang#108523 (Avoid `&str` to `String` conversions)
 - rust-lang#108533 (diagnostics: avoid querying `associated_item` in the resolver)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 2375d7f into rust-lang:master Feb 27, 2023
@rustbot rustbot added this to the 1.69.0 milestone Feb 27, 2023
@bjorn3 bjorn3 deleted the faster_bootstrap_build branch February 27, 2023 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@klensy klensy klensy left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@albertlarsan68 albertlarsan68

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Projects

None yet

Milestone

1.69.0

Development

Successfully merging this pull request may close these issues.

5 participants

@bjorn3 @rustbot @albertlarsan68 @bors @klensy