Skip to content

Properly check for builtin derived code #108128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 20, 2023
Merged

Properly check for builtin derived code #108128

merged 1 commit into from
Feb 20, 2023

Conversation

@clubby789
Copy link
Contributor

@clubby789 clubby789 commented Feb 16, 2023 •
edited
Loading

Fixes #108122

@rustbot
Copy link
Collaborator

rustbot commented Feb 16, 2023

r? @jackh726

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Feb 16, 2023
@rustbot
Copy link
Collaborator

rustbot commented Feb 16, 2023

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@compiler-errors
Copy link
Member

Should this be a rustc_* attr rather than have its own feature gate?

@clubby789
Copy link
Contributor Author

I didn't make it rustc_ since the macros are technically (at least at the place where the allow_internal_unstable is) part of std rather than rustc but I'll move it if you think that makes more sense

compiler-errors
compiler-errors reviewed Feb 16, 2023
View reviewed changes
@clubby789 clubby789 force-pushed the builtin-derived-attr branch from cbf518c to d42627f Compare February 16, 2023 18:49
@clubby789 clubby789 changed the title Implement builtin_derived attr Properly check for builtin derived code Feb 16, 2023
@clubby789
Copy link
Contributor Author

clubby789 commented Feb 16, 2023 •
edited
Loading

Updated to check for an automatically_derived trait impl that comes from an expansion of a derive macro annotated rustc_builtin_macro

@rustbot label -T-libs

@clubby789 clubby789 force-pushed the builtin-derived-attr branch from d42627f to 59512d9 Compare February 16, 2023 19:26
@clubby789 clubby789 force-pushed the builtin-derived-attr branch from 59512d9 to 90f642b Compare February 16, 2023 19:44
@rustbot rustbot removed the T-libs Relevant to the library team, which will review and decide on the PR/issue. label Feb 16, 2023
@jackh726
Copy link
Member

@bors r+

@bors
Copy link
Collaborator

bors commented Feb 18, 2023

📌 Commit 90f642b has been approved by jackh726

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 18, 2023
@bors
Copy link
Collaborator

bors commented Feb 19, 2023

⌛ Testing commit 90f642b with merge a56d216122f14e2cc26dffbf3304e85b2dcaee2d...

@bors
Copy link
Collaborator

bors commented Feb 19, 2023

💥 Test timed out

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 19, 2023
@tmiasko
Copy link
Contributor

tmiasko commented Feb 19, 2023

@bors retry timeout

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 19, 2023
@bors
Copy link
Collaborator

bors commented Feb 19, 2023

⌛ Testing commit 90f642b with merge 21e5b94...

@bors
Copy link
Collaborator

bors commented Feb 20, 2023

☀️ Test successful - checks-actions
Approved by: jackh726
Pushing 21e5b94 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Feb 20, 2023
@bors bors merged commit 21e5b94 into rust-lang:master Feb 20, 2023
@rustbot rustbot added this to the 1.69.0 milestone Feb 20, 2023
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (21e5b94): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

This benchmark run did not return any relevant results for this metric.

@matthiaskrgr matthiaskrgr mentioned this pull request Nov 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@compiler-errors compiler-errors compiler-errors left review comments

Assignees

@jackh726 jackh726

Labels

merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.69.0

Development

Successfully merging this pull request may close these issues.

ICE in unaligned references MIR check

7 participants

@clubby789 @rustbot @compiler-errors @jackh726 @bors @tmiasko @rust-timer