rustdoc: Don't resolve link to field on different variant #107912
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
clubby789
force-pushed
the
doc-bad-enum-field
branch
from
38c8e8d to
67c3915
Compare
camelid
reviewed
Feb 11, 2023
camelid
reviewed
Feb 11, 2023
clubby789
force-pushed
the
doc-bad-enum-field
branch
from
67c3915 to
ef8de38
Compare
|
That's right - tested with the example from the linked issue |
GuillaumeGomez
approved these changes
Feb 11, 2023
|
Thanks for this improvement! @bors r=camelid,GuillaumeGomez rollup |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 11, 2023
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#107657 (Add only modified subcommand for compiletest) - rust-lang#107864 (rustdoc: clean up `write!` calls with less stuttering) - rust-lang#107873 (Emit JSON output for the building of bootstrap itself) - rust-lang#107895 (remove redundant clones) - rust-lang#107897 (Reexported macros docs) - rust-lang#107909 (rustdoc: remove redundant `if s.is_empty()` from `find_testable_code`) - rust-lang#107912 (rustdoc: Don't resolve link to field on different variant) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #107903
This also gives a more specific diagnostic when the enum has any fields