Use can_eq to compare types for default assoc type error
#107304
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
Noratrieb
force-pushed
the
ᐸTy as PartialEqᐳ：：eq because what else are we gonna use in rustc_middle
branch
from
3e98b8f to
4ffd068
Compare
Noratrieb
commented
Jan 25, 2023
There was a problem hiding this comment.
Moving this here so it can use IntoQueryParam just like def_kind above.
Noratrieb
force-pushed
the
ᐸTy as PartialEqᐳ：：eq because what else are we gonna use in rustc_middle
branch
from
4ffd068 to
35ce21b
Compare
This way we can properly deal with the types.
This works correctly with inference variables.
Noratrieb
force-pushed
the
ᐸTy as PartialEqᐳ：：eq because what else are we gonna use in rustc_middle
branch
from
35ce21b to
943000f
Compare
|
r? @compiler-errors Looks good to me! |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 26, 2023
…iaskrgr Rollup of 9 pull requests Successful merges: - rust-lang#97373 (impl DispatchFromDyn for Cell and UnsafeCell) - rust-lang#106625 (Remove backwards compat for LLVM 12 coverage format) - rust-lang#106779 (Avoid __cxa_thread_atexit_impl on Emscripten) - rust-lang#106811 (Append .dwp to the binary filename instead of replacing the existing extension.) - rust-lang#106836 (Remove optimistic spinning from `mpsc::SyncSender`) - rust-lang#106946 (implement Hash for proc_macro::LineColumn) - rust-lang#107074 (remove unnecessary check for opaque types) - rust-lang#107287 (Improve fn pointer notes) - rust-lang#107304 (Use `can_eq` to compare types for default assoc type error) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Noratrieb
deleted the
ᐸTy as PartialEqᐳ：：eq because what else are we gonna use in rustc_middle
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This correctly handles inference variables like
{integer}. I had to move all of thisnote_and_explaincode torustc_infer, it made no sense for it to be inrustc_middleanyways.The commits are reviewed separately.
Fixes #106968