Skip to content

Deny having src/test exisiting in tidy #106734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 12, 2023
Merged

Deny having src/test exisiting in tidy #106734

merged 1 commit into from
Jan 12, 2023

Conversation

albertlarsan68
Copy link
Member

Fixes #106724

@rustbot
Copy link
Collaborator

rustbot commented Jan 11, 2023

r? @Mark-Simulacrum

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 11, 2023
@Noratrieb
Copy link
Member

Looks great!
tidy error: Tests have been moved, please move them from /home/nilsh/projects/rust/src/test to /home/nilsh/projects/rust/tests

r? Nilstrieb
@bors r+

@bors
Copy link
Collaborator

bors commented Jan 11, 2023

📌 Commit ebd3352 has been approved by Nilstrieb

It is now in the queue for this repository.

@rustbot rustbot assigned Noratrieb and unassigned Mark-Simulacrum Jan 11, 2023
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 11, 2023
@albertlarsan68
Copy link
Member Author

@bors r=2 prevents future PR breakage

@bors
Copy link
Collaborator

bors commented Jan 11, 2023

@albertlarsan68: 🔑 Insufficient privileges: Not in reviewers

@albertlarsan68
Copy link
Member Author

@Nilstrieb Please

bors r=2 prevents future PR breakage

@matthiaskrgr matthiaskrgr mentioned this pull request Jan 11, 2023
Merged
@Noratrieb
Copy link
Member

@bors p=1

@dtolnay dtolnay mentioned this pull request Jan 11, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 11, 2023
@bors
Auto merge of rust-lang#106743 - matthiaskrgr:rollup-q5dpxms, r=matth…
56ee65a 
…iaskrgr

Rollup of 6 pull requests

Successful merges:

 - rust-lang#106620 (Detect struct literal needing parentheses)
 - rust-lang#106622 (Detect out of bounds range pattern value)
 - rust-lang#106703 (Note predicate span on `ImplDerivedObligation`)
 - rust-lang#106705 (Report fulfillment errors in new trait solver)
 - rust-lang#106726 (Fix some typos in code comments.)
 - rust-lang#106734 (Deny having src/test exisiting in tidy)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors
Copy link
Collaborator

bors commented Jan 12, 2023

⌛ Testing commit ebd3352 with merge 56ee65a...

@bors bors merged commit 106df9e into rust-lang:master Jan 12, 2023
@rustbot rustbot added this to the 1.68.0 milestone Jan 12, 2023
@albertlarsan68 albertlarsan68 deleted the deny-src-tests-in-tidy branch January 12, 2023 08:25
@klensy klensy mentioned this pull request Jan 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Noratrieb Noratrieb

Labels
A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.68.0
Development

Successfully merging this pull request may close these issues.

Add a tidy check to prevent from adding a new test to src/test
5 participants
@albertlarsan68 @rustbot @Noratrieb @bors @Mark-Simulacrum