Point at expressions where inference refines an unexpected type #106400

estebank · 2023-01-03T05:07:22Z

error[E0308]: mismatched types
  --> src/test/ui/type/type-check/point-at-inference.rs:12:9
   |
9  |         foo.push(i);
   |                  - this is of type `&{integer}`, which makes `foo` to be inferred as `Vec<&{integer}>`
...
12 |     bar(foo);
   |     --- ^^^ expected `i32`, found `&{integer}`
   |     |
   |     arguments to this function are incorrect
   |
   = note: expected struct `Vec<i32>`
              found struct `Vec<&{integer}>`
note: function defined here
  --> src/test/ui/type/type-check/point-at-inference.rs:2:4
   |
2  | fn bar(_: Vec<i32>) {}
   |    ^^^ -----------
help: consider dereferencing the borrow
   |
9  |         foo.push(*i);
   |                  +

rustbot · 2023-01-03T05:07:27Z

r? @compiler-errors

(rustbot has picked a reviewer for you, use r? to override)

compiler/rustc_hir_typeck/src/demand.rs

...test/ui/rfc-2497-if-let-chains/ensure-that-let-else-does-not-interact-with-let-chains.stderr

src/test/ui/span/coerce-suggestions.stderr

compiler/rustc_hir_typeck/src/demand.rs

src/test/ui/closures/closure-return-type-mismatch.stderr

compiler/rustc_hir_typeck/src/demand.rs

compiler/rustc_hir_typeck/src/expr.rs

compiler/rustc_hir_typeck/src/demand.rs

estebank · 2023-01-04T04:51:45Z

@compiler-errors I think I addressed all of your previous comments

compiler/rustc_hir_typeck/src/demand.rs

compiler-errors · 2023-01-05T00:40:04Z

Hm, I'm not sure if I fully grasp some of this method argument stuff, since it seems like this PR got rewritten since I last reviewed it. Need to spend some time reasoning with some of this logic.

compiler-errors

one nit: "make" here is a synonym of "cause" but I'm not sure if it works with the same construction?

r=me -- I may take a stab at this method code a bit later, but I don't want to block you and I'm still trying to think of a way to avoid theCollectAllMismatches usage here.

compiler/rustc_hir_typeck/src/demand.rs

estebank · 2023-01-05T01:44:30Z

@bors r=compiler-errors

bors · 2023-01-05T01:44:32Z

📌 Commit 25cf71e has been approved by compiler-errors

It is now in the queue for this repository.

Point at expressions where inference refines an unexpected type Fix rust-lang#106355. Fix rust-lang#14007. (!) ``` error[E0308]: mismatched types --> src/test/ui/type/type-check/point-at-inference.rs:12:9 | 9 | foo.push(i); | - this is of type `&{integer}`, which makes `foo` to be inferred as `Vec<&{integer}>` ... 12 | bar(foo); | --- ^^^ expected `i32`, found `&{integer}` | | | arguments to this function are incorrect | = note: expected struct `Vec<i32>` found struct `Vec<&{integer}>` note: function defined here --> src/test/ui/type/type-check/point-at-inference.rs:2:4 | 2 | fn bar(_: Vec<i32>) {} | ^^^ ----------- help: consider dereferencing the borrow | 9 | foo.push(*i); | + ```

bors · 2023-01-05T09:44:59Z

⌛ Testing commit 25cf71e with merge cfbc12774406f0ed9a269e2c28275de9e0a45330...

bors · 2023-01-05T09:49:59Z

💔 Test failed - checks-actions

estebank · 2023-01-05T16:38:20Z

I'm very confused by this merge conflict, pulling and rebasing still builds 👀

- Only point at a the single expression where the found type was first inferred. - Find method call argument that might have caused the found type to be inferred. - Provide structured suggestion. - Apply some review comments. - Tweak wording.

```rust fn main() { let v = Vec::new(); v.push(0); v.push(0); v.push(""); } ``` now produces ``` error[E0308]: mismatched types --> $DIR/point-at-inference-3.rs:6:12 | LL | v.push(0); | - this is of type `{integer}`, which makes `v` to be inferred as `Vec<{integer}>` ... LL | v.push(""); | ---- ^^ expected integer, found `&str` | | | arguments to this function are incorrect | note: associated function defined here --> $SRC_DIR/alloc/src/vec/mod.rs:LL:COL ```

…match

estebank · 2023-01-05T17:10:07Z

@bors r=compiler-errors

bors · 2023-01-05T17:10:09Z

📌 Commit f98f2fc has been approved by compiler-errors

It is now in the queue for this repository.

bors · 2023-01-05T18:28:34Z

⌛ Testing commit f98f2fc with merge 6660916f5ebc99a31603558493a43b72f7189242...

bors · 2023-01-05T22:43:34Z

💥 Test timed out

estebank · 2023-01-05T23:34:37Z

@bors retry

rust-log-analyzer · 2023-01-05T23:43:52Z

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

Rollup of 5 pull requests Successful merges: - rust-lang#106400 (Point at expressions where inference refines an unexpected type) - rust-lang#106491 (Fix error-index redirect to work with the back button.) - rust-lang#106494 (Add regression test for rust-lang#58355) - rust-lang#106499 (fix [type error] for error E0029 and E0277) - rust-lang#106502 (rustdoc: remove legacy user-select CSS) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup

rustbot assigned compiler-errors Jan 3, 2023

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 3, 2023

compiler-errors reviewed Jan 3, 2023

View reviewed changes

estebank commented Jan 3, 2023

View reviewed changes

compiler/rustc_hir_typeck/src/demand.rs Outdated Show resolved Hide resolved

compiler-errors reviewed Jan 3, 2023

View reviewed changes

compiler/rustc_hir_typeck/src/expr.rs Show resolved Hide resolved

estebank commented Jan 3, 2023

View reviewed changes

compiler/rustc_hir_typeck/src/demand.rs Show resolved Hide resolved

estebank force-pushed the type-errs branch from 2a38bbb to 294efc2 Compare January 3, 2023 07:34

estebank force-pushed the type-errs branch 3 times, most recently from 095a33e to b3488b2 Compare January 5, 2023 00:38

compiler-errors reviewed Jan 5, 2023

View reviewed changes

compiler/rustc_hir_typeck/src/demand.rs Show resolved Hide resolved

compiler/rustc_hir_typeck/src/demand.rs Show resolved Hide resolved

compiler/rustc_hir_typeck/src/demand.rs Outdated Show resolved Hide resolved

estebank mentioned this pull request Jan 5, 2023

Type errors of the form "expected... but found..." should indicate the source of their expectation #14007

Closed

compiler-errors reviewed Jan 5, 2023

View reviewed changes

compiler/rustc_hir_typeck/src/demand.rs Outdated Show resolved Hide resolved

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 5, 2023

compiler-errors mentioned this pull request Jan 5, 2023

Rollup of 6 pull requests #106480

Closed

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 5, 2023

This comment has been minimized.

Sign in to view

estebank added 8 commits January 5, 2023 16:51

Tweak output

9cc8d86

- Only point at a the single expression where the found type was first inferred. - Find method call argument that might have caused the found type to be inferred. - Provide structured suggestion. - Apply some review comments. - Tweak wording.

Formatting

4ac7d1c

Use BottomUpFolder

ad82eed

Suggest changing argument on type error

f571862

review comment: potentially produce more suggestions for arg type mis…

98f3936

…match

review comments: reword

b182259

fix rebase

f98f2fc

estebank force-pushed the type-errs branch from 25cf71e to f98f2fc Compare January 5, 2023 17:09

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 5, 2023

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 5, 2023

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 5, 2023

Dylan-DPC mentioned this pull request Jan 6, 2023

Rollup of 5 pull requests #106529

Merged

bors merged commit 6ae0f08 into rust-lang:master Jan 6, 2023

rustbot added this to the 1.68.0 milestone Jan 6, 2023

compiler-errors mentioned this pull request Jan 21, 2023

[ICE]: index out of bounds: the len is 27 but the index is 28 snapshot_vec.rs #107158

Closed

Noratrieb mentioned this pull request Mar 2, 2023

rustc: Compiler index error, out of bound #108664

Closed

estebank deleted the type-errs branch November 9, 2023 05:13

Point at expressions where inference refines an unexpected type #106400

Point at expressions where inference refines an unexpected type #106400

Uh oh!

Conversation

estebank commented Jan 3, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Jan 3, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

estebank commented Jan 4, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

compiler-errors commented Jan 5, 2023

Uh oh!

compiler-errors left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

estebank commented Jan 5, 2023

Uh oh!

bors commented Jan 5, 2023

Uh oh!

bors commented Jan 5, 2023

Uh oh!

bors commented Jan 5, 2023

Uh oh!

This comment has been minimized.

estebank commented Jan 5, 2023

Uh oh!

estebank commented Jan 5, 2023

Uh oh!

bors commented Jan 5, 2023

Uh oh!

bors commented Jan 5, 2023

Uh oh!

bors commented Jan 5, 2023

Uh oh!

estebank commented Jan 5, 2023

Uh oh!

rust-log-analyzer commented Jan 5, 2023

Uh oh!

Uh oh!

estebank commented Jan 3, 2023 •

edited

Loading