Skip to content

Migrate toggle-line-inner background to CSS variable #106110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 24, 2022
Merged

Migrate toggle-line-inner background to CSS variable #106110

merged 2 commits into from
Dec 24, 2022

Conversation

@GuillaumeGomez
Copy link
Member

@GuillaumeGomez GuillaumeGomez commented Dec 24, 2022

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Dec 24, 2022
@rustbot
Copy link
Collaborator

rustbot commented Dec 24, 2022

A change occurred in the Ayu theme.

cc @Cldfire

Some changes occurred in HTML/CSS/JS.

cc @GuillaumeGomez, @Folyd, @jsha

@notriddle
Copy link
Contributor

notriddle commented Dec 24, 2022

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Dec 24, 2022

📌 Commit 457f6c8 has been approved by notriddle

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 24, 2022
@bors
Copy link
Collaborator

bors commented Dec 24, 2022

⌛ Testing commit 457f6c8 with merge 46160e6...

@bors
Copy link
Collaborator

bors commented Dec 24, 2022

☀️ Test successful - checks-actions
Approved by: notriddle
Pushing 46160e6 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Dec 24, 2022
@bors bors merged commit 46160e6 into rust-lang:master Dec 24, 2022
@rustbot rustbot added this to the 1.68.0 milestone Dec 24, 2022
@rust-timer
Copy link
Collaborator

rust-timer commented Dec 25, 2022

Finished benchmarking commit (46160e6): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 2.5% [2.5%, 2.5%] 2
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) - - 0

Cycles

This benchmark run did not return any relevant results for this metric.

@GuillaumeGomez GuillaumeGomez deleted the toggle-line-background branch December 25, 2022 14:45
Aaron1011 pushed a commit to Aaron1011/rust that referenced this pull request Jan 6, 2023
@bors
Auto merge of rust-lang#106110 - GuillaumeGomez:toggle-line-backgroun…
2a23d18 
…d, r=notriddle

Migrate toggle-line-inner background to CSS variable

r? `@notriddle`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@notriddle notriddle

Labels

merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.68.0

Development

Successfully merging this pull request may close these issues.

5 participants

@GuillaumeGomez @rustbot @notriddle @bors @rust-timer