Skip to content

Add checks for the signature of the start lang item #106092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 13, 2023
Merged

Add checks for the signature of the start lang item #106092

merged 1 commit into from
Jan 13, 2023

Conversation

asquared31415
Copy link
Contributor

Closes #105963

@rustbot
Copy link
Collaborator

rustbot commented Dec 23, 2022

r? @davidtwco

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added A-translation Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 23, 2022
@rustbot
Copy link
Collaborator

rustbot commented Dec 23, 2022

rustc_error_messages was changed

cc @davidtwco, @compiler-errors, @JohnTitor, @estebank, @TaKO8Ki

@Enselic Enselic mentioned this pull request Dec 26, 2022
Open
23 tasks
davidtwco
davidtwco approved these changes Jan 7, 2023
View reviewed changes
Copy link
Member

@davidtwco davidtwco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, r=me after fixing one nit. Apologies for the delay in getting to this review.

@asquared31415 asquared31415 force-pushed the start_lang_item_checks branch from 3b1825f to a0e560b Compare January 7, 2023 20:14
@BoxyUwU
Copy link
Member

BoxyUwU commented Jan 8, 2023

@bors r=davidtwco

@bors
Copy link
Collaborator

bors commented Jan 8, 2023

📌 Commit a0e560b has been approved by davidtwco

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 8, 2023
compiler-errors added a commit to compiler-errors/rust that referenced this pull request Jan 9, 2023
@compiler-errors
Rollup merge of rust-lang#106092 - asquared31415:start_lang_item_chec…
66729cc 
…ks, r=davidtwco

Add checks for the signature of the `start` lang item

Closes rust-lang#105963
@compiler-errors compiler-errors mentioned this pull request Jan 9, 2023
Closed
@compiler-errors
Copy link
Member

@bors r-

src/tools/clippy/tests/ui/def_id_nocore.rs needs fixing.

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 9, 2023
@asquared31415 asquared31415 force-pushed the start_lang_item_checks branch from a0e560b to e686a44 Compare January 9, 2023 03:30
@rustbot
Copy link
Collaborator

rustbot commented Jan 9, 2023

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

@davidtwco
Copy link
Member

@bors r+

@bors
Copy link
Collaborator

bors commented Jan 9, 2023

📌 Commit e686a44e4bf6d1511cc93edc8440efd0aacdba1c has been approved by davidtwco

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 9, 2023
@dtolnay
Copy link
Member

dtolnay commented Jan 11, 2023

This needs to be rebased past #106458, since it is showing not mergeable in bors.
https://bors.rust-lang.org/queue/rust
@bors r-
@rustbot author

@rustbot rustbot added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jan 11, 2023
@bors bors removed the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jan 11, 2023
@dtolnay
Copy link
Member

dtolnay commented Jan 11, 2023

Here is a rebase on current master: 337a97d

@asquared31415 asquared31415 force-pushed the start_lang_item_checks branch from e686a44 to 337a97d Compare January 12, 2023 21:46
@dtolnay
Copy link
Member

dtolnay commented Jan 12, 2023

@bors r=davidtwco

@bors
Copy link
Collaborator

bors commented Jan 12, 2023

📌 Commit 337a97d has been approved by davidtwco

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 12, 2023
@bors
Copy link
Collaborator

bors commented Jan 13, 2023

⌛ Testing commit 337a97d with merge 4a04f25...

@bors
Copy link
Collaborator

bors commented Jan 13, 2023

☀️ Test successful - checks-actions
Approved by: davidtwco
Pushing 4a04f25 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jan 13, 2023
@bors bors merged commit 4a04f25 into rust-lang:master Jan 13, 2023
@rustbot rustbot added this to the 1.68.0 milestone Jan 13, 2023
@bjorn3 bjorn3 mentioned this pull request Jan 13, 2023
Closed
@bors bors mentioned this pull request Jan 13, 2023
Merged
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (4a04f25): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 2.4% [2.4%, 2.4%] 1
Regressions ❌
(secondary)		 1.8% [1.8%, 1.8%] 1
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -2.2% [-2.2%, -2.2%] 1
All ❌✅ (primary) 2.4% [2.4%, 2.4%] 1

Cycles

This benchmark run did not return any relevant results for this metric.

flip1995 pushed a commit to flip1995/rust that referenced this pull request Jan 27, 2023
@bors
Auto merge of rust-lang#106092 - asquared31415:start_lang_item_checks…
83dba6e 
…, r=davidtwco

Add checks for the signature of the `start` lang item

Closes rust-lang#105963
@asquared31415 asquared31415 deleted the start_lang_item_checks branch June 22, 2023 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidtwco davidtwco davidtwco approved these changes

Assignees

@davidtwco davidtwco

Labels
A-translation Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.68.0
Development

Successfully merging this pull request may close these issues.

Verify signature of start lang item
8 participants
@asquared31415 @rustbot @BoxyUwU @bors @compiler-errors @davidtwco @dtolnay @rust-timer