`impl PartialEq<{str,String}> for {Path,PathBuf}` (and reversed) #105877

Kixunil · 2022-12-18T18:41:28Z

Comparison of paths and strings is expected to be possible and needed e.g. in tests. This change adds the impls os PartialEq between strings and paths, both owned and unsized, in both directions.

Because this is trait impl it's expected to be insta-stable.

ACP: rust-lang/libs-team#151

rustbot · 2022-12-18T18:41:35Z

r? @joshtriplett

(rustbot has picked a reviewer for you, use r? to override)

rustbot · 2022-12-18T18:41:37Z

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

Stabilizing library features
Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
Changing public documentation in ways that create new stability guarantees
Changing observable runtime behavior of library APIs

Kixunil · 2022-12-18T18:41:54Z

@rustbot label +T-libs-api -T-libs

ChrisDenton · 2022-12-20T20:20:22Z

Since this is instantly stable, I think it's worth asking why these weren't implemented before. I doubt this omission was unintentional.

EDIT: Hm, looking at the proposed implementation I think my initial guess as to why was wrong. Still, my question stands,

ChrisDenton · 2022-12-20T20:41:41Z

Ah, looking at the above error it seems like this may cause type inference issues? In which case it would be a breaking change to implement this. See also previous attempts in #31861 and #76189

Kixunil · 2022-12-22T10:14:15Z

@ChrisDenton the errors in CI are just changed outputs in UI tests which is fine. I didn't have time to update them and will be unable for a few days I think. The linked issues seem like people gave up too soon but I will look later if different errors appear.

ChrisDenton · 2022-12-22T10:22:12Z

Fair enough. If it's just the case that people keep giving up too early then I don't have any problem. I just prefer to know, if possible, why something seemingly obvious hasn't been done before rather than assuming it's just an oversight.

bors · 2022-12-28T20:40:41Z

☔ The latest upstream changes (presumably #106215) made this pull request unmergeable. Please resolve the merge conflicts.

Comparison of paths and strings is expected to be possible and needed e.g. in tests. This change adds the impls os `PartialEq` between strings and paths, both owned and unsized, in both directions. ACP: rust-lang/libs-team#151

pitaj · 2023-01-29T01:23:43Z

@rustbot label -S-waiting-on-review +S-waiting-on-ACP

workingjubilee · 2023-07-31T22:20:23Z

r? libs-api

Needs FCP for a bunch of PartialEq between str and String with Path and PathBuf. ACP was already accepted.

workingjubilee · 2023-07-31T22:21:13Z

Though doesn't Deref handle some of them? Hmm...

Amanieu · 2024-11-19T18:12:24Z

This needs a crater run because it has the potential to cause type inference failures. Could you please rebase so that I can start the run?

Amanieu · 2024-11-19T18:13:39Z

@rustbot author

Dylan-DPC · 2025-01-26T12:43:24Z

@Kixunil any updates on this? thanks

Dylan-DPC · 2025-05-08T05:40:10Z

Closing this as inactive. Feel free to reöpen this pr or create a new pr if you get the time to work on this. Thanks

… r=<try> `impl PartialEq<{str,String}> for {Path,PathBuf}` This is a revival of rust-lang#105877 Comparison of paths and strings is expected to be possible and needed e.g. in tests. This change adds the impls os `PartialEq` between strings and paths, both owned and unsized, in both directions. ACP: rust-lang/libs-team#151

…h, r=Amanieu `impl PartialEq<{str,String}> for {Path,PathBuf}` This is a revival of rust-lang#105877 Comparison of paths and strings is expected to be possible and needed e.g. in tests. This change adds the impls os `PartialEq` between strings and paths, both owned and unsized, in both directions. ACP: rust-lang/libs-team#151

Rollup merge of #140956 - Kixunil:impl-partialeq-str-for-path, r=Amanieu `impl PartialEq<{str,String}> for {Path,PathBuf}` This is a revival of #105877 Comparison of paths and strings is expected to be possible and needed e.g. in tests. This change adds the impls os `PartialEq` between strings and paths, both owned and unsized, in both directions. ACP: rust-lang/libs-team#151

…h, r=Amanieu `impl PartialEq<{str,String}> for {Path,PathBuf}` This is a revival of rust-lang#105877 Comparison of paths and strings is expected to be possible and needed e.g. in tests. This change adds the impls os `PartialEq` between strings and paths, both owned and unsized, in both directions. ACP: rust-lang/libs-team#151

rustbot assigned joshtriplett Dec 18, 2022

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Dec 18, 2022

rustbot added T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. and removed T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Dec 18, 2022

Kixunil force-pushed the impl-partialeq-str-for-path branch from 654c4d5 to b8cd820 Compare December 18, 2022 19:28

This comment has been minimized.

Sign in to view

Kixunil force-pushed the impl-partialeq-str-for-path branch from b8cd820 to 6e7082d Compare December 19, 2022 09:42

This comment has been minimized.

Sign in to view

Kixunil force-pushed the impl-partialeq-str-for-path branch 2 times, most recently from 8a4d869 to 3a37672 Compare December 19, 2022 11:06

This comment has been minimized.

Sign in to view

Kixunil force-pushed the impl-partialeq-str-for-path branch from 3a37672 to 5c9f724 Compare January 2, 2023 12:29

impl PartialEq<{str,String}> for {Path,PathBuf}

4813457

Comparison of paths and strings is expected to be possible and needed e.g. in tests. This change adds the impls os `PartialEq` between strings and paths, both owned and unsized, in both directions. ACP: rust-lang/libs-team#151

Kixunil force-pushed the impl-partialeq-str-for-path branch from 5c9f724 to 4813457 Compare January 2, 2023 12:51

rustbot added S-waiting-on-ACP Status: PR has an ACP and is waiting for the ACP to complete. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 29, 2023

pitaj added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-ACP Status: PR has an ACP and is waiting for the ACP to complete. labels May 30, 2023

workingjubilee added the needs-fcp This change is insta-stable, or significant enough to need a team FCP to proceed. label Jul 31, 2023

rustbot assigned m-ou-se and unassigned joshtriplett Jul 31, 2023

Amanieu added the I-libs-api-nominated Nominated for discussion during a libs-api team meeting. label Nov 13, 2024

Amanieu added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed I-libs-api-nominated Nominated for discussion during a libs-api team meeting. S-waiting-on-crater Status: Waiting on a crater run to be completed. labels Nov 19, 2024

Amanieu assigned Amanieu and unassigned m-ou-se Nov 19, 2024

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 19, 2024

Dylan-DPC closed this May 8, 2025

Dylan-DPC added S-inactive Status: Inactive and waiting on the author. This is often applied to closed PRs. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 8, 2025

Kixunil mentioned this pull request May 13, 2025

impl PartialEq<{str,String}> for {Path,PathBuf} #140956

Merged

impl PartialEq<{str,String}> for {Path,PathBuf} (and reversed) #105877

impl PartialEq<{str,String}> for {Path,PathBuf} (and reversed) #105877

Uh oh!

Conversation

Kixunil commented Dec 18, 2022

Uh oh!

rustbot commented Dec 18, 2022

Uh oh!

rustbot commented Dec 18, 2022

Uh oh!

Kixunil commented Dec 18, 2022

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

ChrisDenton commented Dec 20, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ChrisDenton commented Dec 20, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Kixunil commented Dec 22, 2022

Uh oh!

ChrisDenton commented Dec 22, 2022

Uh oh!

bors commented Dec 28, 2022

Uh oh!

pitaj commented Jan 29, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

workingjubilee commented Jul 31, 2023

Uh oh!

workingjubilee commented Jul 31, 2023

Uh oh!

Amanieu commented Nov 19, 2024

Uh oh!

Amanieu commented Nov 19, 2024

Uh oh!

Dylan-DPC commented Jan 26, 2025

Uh oh!

Dylan-DPC commented May 8, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

`impl PartialEq<{str,String}> for {Path,PathBuf}` (and reversed) #105877

`impl PartialEq<{str,String}> for {Path,PathBuf}` (and reversed) #105877

ChrisDenton commented Dec 20, 2022 •

edited

Loading

ChrisDenton commented Dec 20, 2022 •

edited

Loading

pitaj commented Jan 29, 2023 •

edited

Loading