Skip to content

fix: remove hack from link.rs #105418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 8, 2022
Merged

fix: remove hack from link.rs #105418

merged 1 commit into from
Dec 8, 2022

Conversation

belovdv
Copy link
Contributor

@belovdv belovdv commented Dec 7, 2022 •
edited by petrochenkov
Loading

This logic implemented in libc in rust-lang/libc#3013.

r? @petrochenkov

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Dec 7, 2022
@petrochenkov
Copy link
Contributor

@bors r+

@bors
Copy link
Collaborator

bors commented Dec 7, 2022

📌 Commit a9cf163 has been approved by petrochenkov

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 7, 2022
@matthiaskrgr matthiaskrgr mentioned this pull request Dec 7, 2022
Merged
@mati865
Copy link
Member

mati865 commented Dec 8, 2022

Can you point to commit that fixed it on libc side?

bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 8, 2022
@bors
Auto merge of rust-lang#105425 - matthiaskrgr:rollup-3ngvxmt, r=matth…
f5418b0 
…iaskrgr

Rollup of 6 pull requests

Successful merges:

 - rust-lang#105267 (Don't ICE in ExprUseVisitor on FRU for non-existent struct)
 - rust-lang#105343 (Simplify attribute handling in rustc_ast_lowering)
 - rust-lang#105368 (Remove more `ref` patterns from the compiler)
 - rust-lang#105400 (normalize before handling simple checks for evaluatability of `ty::Const`)
 - rust-lang#105403 (rustdoc: simplify CSS selectors for item table `.stab`)
 - rust-lang#105418 (fix: remove hack from link.rs)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 4968af0 into rust-lang:master Dec 8, 2022
@rustbot rustbot added this to the 1.67.0 milestone Dec 8, 2022
@petrochenkov
Copy link
Contributor

@mati865 It's rust-lang/libc#3013.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@petrochenkov petrochenkov

Labels
A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.67.0
Development

Successfully merging this pull request may close these issues.
5 participants
@belovdv @petrochenkov @bors @mati865 @rustbot