Skip to content

Avoid ICE if the Clone trait is not found while building error suggestions #104956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 28, 2022
Merged

Avoid ICE if the Clone trait is not found while building error suggestions #104956

merged 1 commit into from
Nov 28, 2022

Conversation

mucinoab
Copy link
Contributor

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 26, 2022
compiler-errors
compiler-errors reviewed Nov 26, 2022
View reviewed changes
@compiler-errors
Copy link
Member

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Nov 26, 2022

📌 Commit 2343353 has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 26, 2022
@compiler-errors compiler-errors mentioned this pull request Nov 27, 2022
Closed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Nov 27, 2022
@matthiaskrgr
Rollup merge of rust-lang#104956 - mucinoab:issue-104870, r=compiler-…
3f25e34 
…errors

Avoid ICE if the Clone trait is not found while building error suggestions

Fixes rust-lang#104870

r? `@compiler-errors`
This was referenced Nov 27, 2022
Closed
Closed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Nov 27, 2022
@matthiaskrgr
Rollup merge of rust-lang#104956 - mucinoab:issue-104870, r=compiler-…
4d62c79 
…errors

Avoid ICE if the Clone trait is not found while building error suggestions

Fixes rust-lang#104870

r? ``@compiler-errors``
@matthiaskrgr matthiaskrgr mentioned this pull request Nov 27, 2022
Closed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Nov 27, 2022
@matthiaskrgr
Rollup merge of rust-lang#104956 - mucinoab:issue-104870, r=compiler-…
4990ab8 
…errors

Avoid ICE if the Clone trait is not found while building error suggestions

Fixes rust-lang#104870

r? ```@compiler-errors```
@compiler-errors
Copy link
Member

@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 27, 2022
compiler-errors
compiler-errors reviewed Nov 27, 2022
View reviewed changes
@mucinoab
Copy link
Contributor Author

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 28, 2022
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@compiler-errors
Copy link
Member

@bors r+

@bors
Copy link
Collaborator

bors commented Nov 28, 2022

📌 Commit 7a378dd has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 28, 2022
@matthiaskrgr matthiaskrgr mentioned this pull request Nov 28, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 28, 2022
@bors
Auto merge of rust-lang#105017 - matthiaskrgr:rollup-j0x550l, r=matth…
2585bce 
…iaskrgr

Rollup of 9 pull requests

Successful merges:

 - rust-lang#104804 (Rename `ast::Lit` as `ast::MetaItemLit`.)
 - rust-lang#104891 (Add documentation for `has_escaping_bound_vars`)
 - rust-lang#104933 (interpret: remove PartialOrd from a bunch of types that do not have or need a sensible order)
 - rust-lang#104936 (Ignore bivariant parameters in test_type_match.)
 - rust-lang#104954 (make simple check of prinf function)
 - rust-lang#104956 (Avoid ICE if the Clone trait is not found while building error suggestions)
 - rust-lang#104982 (interpret: get rid of run() function)
 - rust-lang#104998 (Update my mailmap)
 - rust-lang#105006 (stricter alignment enforcement for ScalarPair)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit db2850c into rust-lang:master Nov 28, 2022
@rustbot rustbot added this to the 1.67.0 milestone Nov 28, 2022
@mucinoab mucinoab deleted the issue-104870 branch November 29, 2022 01:47
Aaron1011 pushed a commit to Aaron1011/rust that referenced this pull request Jan 6, 2023
@matthiaskrgr
Rollup merge of rust-lang#104956 - mucinoab:issue-104870, r=compiler-…
874723c 
…errors

Avoid ICE if the Clone trait is not found while building error suggestions

Fixes rust-lang#104870

r? `@compiler-errors`
Aaron1011 pushed a commit to Aaron1011/rust that referenced this pull request Jan 6, 2023
@bors
Auto merge of rust-lang#105017 - matthiaskrgr:rollup-j0x550l, r=matth…
f60138a 
…iaskrgr

Rollup of 9 pull requests

Successful merges:

 - rust-lang#104804 (Rename `ast::Lit` as `ast::MetaItemLit`.)
 - rust-lang#104891 (Add documentation for `has_escaping_bound_vars`)
 - rust-lang#104933 (interpret: remove PartialOrd from a bunch of types that do not have or need a sensible order)
 - rust-lang#104936 (Ignore bivariant parameters in test_type_match.)
 - rust-lang#104954 (make simple check of prinf function)
 - rust-lang#104956 (Avoid ICE if the Clone trait is not found while building error suggestions)
 - rust-lang#104982 (interpret: get rid of run() function)
 - rust-lang#104998 (Update my mailmap)
 - rust-lang#105006 (stricter alignment enforcement for ScalarPair)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compiler-errors compiler-errors compiler-errors left review comments

Assignees

@compiler-errors compiler-errors

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.67.0
Development

Successfully merging this pull request may close these issues.

ICE: error was constructed but not emitted
5 participants
@mucinoab @compiler-errors @bors @rust-log-analyzer @rustbot