Assert that we don't capture escaping bound vars in Fn trait selection
#104841
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @estebank (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
|
@bors r+ |
|
📌 Commit 770c3416aa3798ea7c003946a1999bc948b8b961 has been approved by It is now in the queue for this repository. |
bors
added
S-waiting-on-bors
|
Hold up, wanted to add a check for fn pointers too while we're at it. |
|
@bors r+ |
|
📌 Commit 86c5f0a8347c7b0eea54e9770979a46437a43a68 has been approved by It is now in the queue for this repository. |
oli-obk
reviewed
Nov 24, 2022
compiler/rustc_trait_selection/src/traits/select/confirmation.rs
Outdated
Show resolved
Hide resolved
|
@bors r=jackh726 |
|
📌 Commit 581ee96d40314cc88d6a5698c1da7eed8e8fb37d has been approved by It is now in the queue for this repository. |
|
☔ The latest upstream changes (presumably #104321) made this pull request unmergeable. Please resolve the merge conflicts. |
bors
added
S-waiting-on-author
compiler-errors
force-pushed
the
fishy-bound-var
branch
from
581ee96 to
d945967
Compare
|
@bors r=jackh726 |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 24, 2022
…iaskrgr Rollup of 11 pull requests Successful merges: - rust-lang#104514 (Use node_ty_opt to avoid ICE in visit_ty) - rust-lang#104704 (Allow power10-vector feature in PowerPC) - rust-lang#104747 (resolve: Don't use constructor def ids in the map for field names) - rust-lang#104773 (OpaqueCast projections are always overlapping, they can't possibly be disjoint) - rust-lang#104774 (Document split{_ascii,}_whitespace() for empty strings) - rust-lang#104780 (make `error_reported` check for delayed bugs) - rust-lang#104782 (Bump the const eval step limit) - rust-lang#104792 (rustdoc: simplify `.search-results-title` CSS) - rust-lang#104796 (lint: do not warn unused parens around higher-ranked function pointers) - rust-lang#104820 (Remove normalize_projection_type) - rust-lang#104822 (with_query_mode -> new) Failed merges: - rust-lang#104716 (move 2 candidates into builtin candidate) - rust-lang#104841 (Assert that we don't capture escaping bound vars in `Fn` trait selection) r? `@ghost` `@rustbot` modify labels: rollup
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Nov 25, 2022
…=jackh726 Assert that we don't capture escaping bound vars in `Fn` trait selection Fixes rust-lang#104825
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 25, 2022
…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#103648 (Don't set `is_preview` for clippy and rustfmt) - rust-lang#104654 (Add `#![deny(unsafe_op_in_unsafe_fn)]` in liballoc tests) - rust-lang#104793 (unstable-book: Add page for the `abi_efiapi` feature) - rust-lang#104841 (Assert that we don't capture escaping bound vars in `Fn` trait selection) - rust-lang#104849 (Migrate source code elements style to CSS variables) - rust-lang#104873 (RefCell::get_mut: fix typo) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #104825