Skip to content

Conversation

lcnr
Copy link
Contributor

@lcnr lcnr commented Nov 17, 2022

want to open a PR to make it easier to review the current changes. This is not yet ready for review.

r? @ghost

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Nov 17, 2022
@rust-log-analyzer

This comment has been minimized.

@rust-log-analyzer
Copy link
Collaborator

The job x86_64-gnu-llvm-13 failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)
   Compiling rustc_fs_util v0.0.0 (/checkout/compiler/rustc_fs_util)
   Compiling either v1.6.0
   Compiling datafrog v2.0.1
   Compiling rustc_apfloat v0.0.0 (/checkout/compiler/rustc_apfloat)
error[E0275]: overflow evaluating the requirement `<int::PInt<U> as Mul<_>>::Output`
   --> /cargo/registry/src/github.com-1ecc6299db9ec823/typenum-1.12.0/src/array.rs:210:25
    |
210 |             first: self * rhs.first,
    |
    = help: consider increasing the recursion limit by adding a `#![recursion_limit = "256"]` attribute to your crate (`typenum`)


error[E0275]: overflow evaluating the requirement `<int::NInt<U> as Mul<_>>::Output`
   --> /cargo/registry/src/github.com-1ecc6299db9ec823/typenum-1.12.0/src/array.rs:225:25
    |
225 |             first: self * rhs.first,
    |
    = help: consider increasing the recursion limit by adding a `#![recursion_limit = "256"]` attribute to your crate (`typenum`)

For more information about this error, try `rustc --explain E0275`.

@bors
Copy link
Collaborator

bors commented Nov 18, 2022

☔ The latest upstream changes (presumably #104555) made this pull request unmergeable. Please resolve the merge conflicts.

@lcnr
Copy link
Contributor Author

lcnr commented Dec 6, 2022

decided after the t-types meetup that we will not try to modify evaluate in place but instead replace it with a solver with a newly written skeleton. Closing this.

@lcnr lcnr closed this Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants