Mark trait_upcasting feature no longer incomplete.
#104117
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
|
Hmm, I would have expected changes to tests? |
This is because all existing tests have |
|
yes - this is why I generally shy against |
|
Ok, i will. |
crlf0710
force-pushed
the
update_feature_gate
branch
from
0bf9664 to
3074678
Compare
|
Updated tests. |
|
@bors r+ |
bors
added
S-waiting-on-bors
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Nov 10, 2022
…ckh726 Mark `trait_upcasting` feature no longer incomplete. This marks the `trait_upcasting` feature no longer incomplete since rust-lang#101336 has been settled for a little while. r? `@jackh726`
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Nov 10, 2022
…ckh726 Mark `trait_upcasting` feature no longer incomplete. This marks the `trait_upcasting` feature no longer incomplete since rust-lang#101336 has been settled for a little while. r? ``@jackh726``
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Nov 11, 2022
…ckh726 Mark `trait_upcasting` feature no longer incomplete. This marks the `trait_upcasting` feature no longer incomplete since rust-lang#101336 has been settled for a little while. r? ``@jackh726``
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Nov 11, 2022
…ckh726 Mark `trait_upcasting` feature no longer incomplete. This marks the `trait_upcasting` feature no longer incomplete since rust-lang#101336 has been settled for a little while. r? ```@jackh726```
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Nov 11, 2022
…ckh726 Mark `trait_upcasting` feature no longer incomplete. This marks the `trait_upcasting` feature no longer incomplete since rust-lang#101336 has been settled for a little while. r? ````@jackh726````
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Nov 12, 2022
…ckh726 Mark `trait_upcasting` feature no longer incomplete. This marks the `trait_upcasting` feature no longer incomplete since rust-lang#101336 has been settled for a little while. r? `````@jackh726`````
This was referenced Nov 12, 2022
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 12, 2022
…llaumeGomez Rollup of 8 pull requests Successful merges: - rust-lang#104110 (prevent uninitialized access in black_box for zero-sized-types) - rust-lang#104117 (Mark `trait_upcasting` feature no longer incomplete.) - rust-lang#104144 (Suggest removing unnecessary `.` to use a floating point literal) - rust-lang#104250 (Migrate no result page link color to CSS variables) - rust-lang#104261 (More accurately report error when formal and expected signature types differ) - rust-lang#104263 (Add a reference to ilog2 in leading_zeros integer docs) - rust-lang#104308 (Remove the old `ValidAlign` name) - rust-lang#104319 (Fix non clickable source link) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This marks the
trait_upcastingfeature no longer incomplete since #101336 has been settled for a little while.r? @jackh726