Skip to content

Make mir opt unused file check blessable #103956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 5, 2022
Merged

Make mir opt unused file check blessable #103956

merged 1 commit into from
Nov 5, 2022

Conversation

JakobDegen
Copy link
Contributor

@JakobDegen JakobDegen commented Nov 4, 2022 •
edited
Loading

Makes it slightly nicer to work with.

Can't write automated test but tested locally via

$ touch src/test/mir-opt/random
$ x test tidy // shows failure
$ x test tidy --bless // file gone

r? @jyn514

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 4, 2022
@jyn514
Copy link
Member

jyn514 commented Nov 4, 2022

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Nov 4, 2022

📌 Commit d98cce1 has been approved by jyn514

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 4, 2022
@matthiaskrgr matthiaskrgr mentioned this pull request Nov 4, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 5, 2022
@bors
Auto merge of rust-lang#103991 - matthiaskrgr:rollup-tj53nte, r=matth…
aebf7c4 
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#103868 (Use `TraitEngine` (by itself) less)
 - rust-lang#103878 (Fix artifact version/channel detection for stable)
 - rust-lang#103946 (Cleanup bind_pattern args)
 - rust-lang#103956 (Make mir opt unused file check blessable)
 - rust-lang#103977 (LLVM 16: Switch to using MemoryEffects)
 - rust-lang#103980 (rustdoc: simplify search results CSS and DOM)
 - rust-lang#103984 (Refactor tcx mk_const parameters.)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit b1a47d2 into rust-lang:master Nov 5, 2022
@rustbot rustbot added this to the 1.67.0 milestone Nov 5, 2022
@JakobDegen JakobDegen deleted the tidy-bless branch November 9, 2022 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@jyn514 jyn514 jyn514 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@jyn514 jyn514

Labels
A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.67.0
Development

Successfully merging this pull request may close these issues.
4 participants
@JakobDegen @jyn514 @bors @rustbot