- 
                Notifications
    You must be signed in to change notification settings 
- Fork 13.9k
Add test for issue 98634 #103342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
    
                
     Merged
            
            Add test for issue 98634 #103342
Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    | (rust-highfive has picked a reviewer for you, use r? to override) | 
      
        
              This comment has been minimized.
        
        
      
    
  This comment has been minimized.
| How do I add  | 
| In other words, how do I make this test work? | 
              
                    compiler-errors
  
              
              requested changes
              
                  
                    Oct 28, 2022 
                  
              
              
            
            
| Should be good now if I never mess up something else. @compiler-errors Thanks a bunch for your quick help and review. | 
| @bors r+ rollup | 
    
  Dylan-DPC 
      added a commit
        to Dylan-DPC/rust
      that referenced
      this pull request
    
      Oct 28, 2022 
    
    
      
  
    
      
    
  
…, r=compiler-errors Add test for issue 98634 Fixes rust-lang#98634
    
  Dylan-DPC 
      added a commit
        to Dylan-DPC/rust
      that referenced
      this pull request
    
      Oct 28, 2022 
    
    
      
  
    
      
    
  
…, r=compiler-errors Add test for issue 98634 Fixes rust-lang#98634
    
  matthiaskrgr 
      added a commit
        to matthiaskrgr/rust
      that referenced
      this pull request
    
      Oct 29, 2022 
    
    
      
  
    
      
    
  
…, r=compiler-errors Add test for issue 98634 Fixes rust-lang#98634
    
  bors 
      added a commit
        to rust-lang-ci/rust
      that referenced
      this pull request
    
      Oct 29, 2022 
    
    
      
  
    
      
    
  
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#102961 (Make `CStr::from_ptr` `const`.) - rust-lang#103342 (Add test for issue 98634) - rust-lang#103383 (Note scope of TAIT more accurately) - rust-lang#103656 (Specialize ToString for Symbol) - rust-lang#103663 (rustdoc: remove redundant CSS/DOM `div.search-container`) - rust-lang#103664 (rustdoc-json-types: Improve ItemSummary::path docs) - rust-lang#103704 (Add a test for TAIT used with impl/dyn Trait inside RPIT) Failed merges: - rust-lang#103618 (Rename some `OwnerId` fields.) r? `@ghost` `@rustbot` modify labels: rollup
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      Labels
      
    S-waiting-on-bors
  Status: Waiting on bors to run and complete tests. Bors will change the label on completion. 
  
    T-compiler
  Relevant to the compiler team, which will review and decide on the PR/issue. 
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Fixes #98634