Skip to content

Conversation

JohnTitor
Copy link
Member

Successful merges:

Failed merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

andrewpollack and others added 12 commits October 13, 2022 21:26
The final return value doesn't need to be tried at all -- we can just
return the checked option directly. The optimizer can probably figure
this out anyway, but there's no need to make it work here.
…tmandry

Adding `fuchsia-ignore` and `needs-unwind` to compiler test cases

Final tests covering missing privileges

r? ``@tmandry``

cc. ``@djkoloski``
Make diagnostic for unsatisfied `Termination` bounds more precise

Don't blindly emit a diagnostic claiming that “*`main` has an invalid return type*” if we encounter a type that should but doesn't implement `std::process::Termination` and isn't actually the return type of the program entry `main`.

Fixes rust-lang#103052.

``@rustbot`` label A-diagnostics T-compiler T-libs
r? diagnostics
…-Simulacrum

Fix typo in `ReverseSearcher` docs
…=Mark-Simulacrum

Remove the redundant `Some(try_opt!(..))` in `checked_pow`

The final return value doesn't need to be tried at all -- we can just
return the checked option directly. The optimizer can probably figure
this out anyway, but there's no need to make it work here.
…=scottmcm

Remove all uses of array_assume_init

See rust-lang#103134 (comment)

r? `@scottmcm`
@rustbot rustbot added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Oct 18, 2022
@JohnTitor
Copy link
Member Author

@bors r+ rollup=never p=6

@bors
Copy link
Collaborator

bors commented Oct 18, 2022

📌 Commit 6e7d206 has been approved by JohnTitor

It is now in the queue for this repository.

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Oct 18, 2022
@bors
Copy link
Collaborator

bors commented Oct 18, 2022

⌛ Testing commit 6e7d206 with merge e94827e...

@bors
Copy link
Collaborator

bors commented Oct 18, 2022

☀️ Test successful - checks-actions
Approved by: JohnTitor
Pushing e94827e to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Oct 18, 2022
@bors bors merged commit e94827e into rust-lang:master Oct 18, 2022
@rustbot rustbot added this to the 1.66.0 milestone Oct 18, 2022
@rust-timer
Copy link
Collaborator

📌 Perf builds for each rolled up PR:

PR# Perf Build Sha
#103168 027451c7bddaaea53c9010e7a6d8572de0ba7bea
#103163 903f68517dfb6bc4ba3f12fa28108583dd9dd8f9
#103159 58d232746bc3341db45628bcf3559df1a1abfd62
#103154 edb07bf54998f958a1fab5dcda9b07d4946f3015
#103142 a52c524f948063b2f0517181eac84ae8931e6627
#103023 8b08384a371932c1f210d1453c2bc639798e9f8b

previous master: 21b246587c

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (e94827e): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean1 range count2
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
3.4% [2.3%, 4.6%] 9
Improvements ✅
(primary)
-4.4% [-4.4%, -4.4%] 1
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) -4.4% [-4.4%, -4.4%] 1

Cycles

This benchmark run did not return any relevant results for this metric.

Footnotes

  1. the arithmetic mean of the percent change

  2. number of relevant changes

@JohnTitor JohnTitor deleted the rollup-pwilam1 branch October 18, 2022 22:34
Aaron1011 pushed a commit to Aaron1011/rust that referenced this pull request Jan 6, 2023
Rollup of 6 pull requests

Successful merges:

 - rust-lang#103023 (Adding `fuchsia-ignore` and `needs-unwind` to compiler test cases)
 - rust-lang#103142 (Make diagnostic for unsatisfied `Termination` bounds more precise)
 - rust-lang#103154 (Fix typo in `ReverseSearcher` docs)
 - rust-lang#103159 (Remove the redundant `Some(try_opt!(..))` in `checked_pow`)
 - rust-lang#103163 (Remove all uses of array_assume_init)
 - rust-lang#103168 (Stabilize asm_sym)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants