rustdoc: remove unused CSS .docblock a:not(.srclink)
#102747
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
T-rustdoc
|
Some changes occurred in HTML/CSS/JS. cc @GuillaumeGomez, @Folyd, @jsha |
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @CraftSpider (or someone else) soon. Please see the contribution instructions for more information. |
rust-highfive
added
the
S-waiting-on-review
This selector was added in c7312fb, because the list of impl items could be nested below `docblock`. https://github.com/rust-lang/rust/blob/c7312fbae4979c6d4fdfbd1f55a71cd47d82a480/src/librustdoc/html/render.rs#L3841-L3845 Now that rustdoc toggles have been switched to `<details>`, there shouldn't be any need to put things inside docblock containers just to give them disclosure toggles.
notriddle
force-pushed
the
notriddle/docblock-a-not-srclink
branch
from
82bdf96 to
28b26b7
Compare
GuillaumeGomez
approved these changes
Oct 6, 2022
|
Thanks! r=me once CI pass |
|
@bors r=GuillaumeGomez rollup |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Oct 7, 2022
…-srclink, r=GuillaumeGomez rustdoc: remove unused CSS `.docblock a:not(.srclink)` This selector was added in c7312fb, because the list of impl items could be nested below `docblock`. https://github.com/rust-lang/rust/blob/c7312fbae4979c6d4fdfbd1f55a71cd47d82a480/src/librustdoc/html/render.rs#L3841-L3845 Now that rustdoc toggles have been switched to `<details>`, there shouldn't be any need to put things inside docblock containers just to give them disclosure toggles.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 7, 2022
…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#102577 (Warn about Visual Studio Code branding confusion) - rust-lang#102720 (do not reverse the expected type and found type for ObligationCauseCo…) - rust-lang#102744 (rustdoc: remove unused CSS `.content .item-list`) - rust-lang#102747 (rustdoc: remove unused CSS `.docblock a:not(.srclink)`) - rust-lang#102748 (Disable compressed debug sections on i586-gnu) - rust-lang#102761 (let-else: test else block with non-never uninhabited type) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This selector was added in c7312fb, because the list of impl items could be nested below
docblock.rust/src/librustdoc/html/render.rs
Lines 3841 to 3845 in c7312fb
Now that rustdoc toggles have been switched to
<details>, there shouldn't be any need to put things inside docblock containers just to give them disclosure toggles.