Fix auto-application of associated generic functions with placeholders #101990

clubby789 · 2022-09-18T17:48:17Z

Fixes #101920

rust-highfive · 2022-09-18T17:48:20Z

r? @compiler-errors

(rust-highfive has picked a reviewer for you, use r? to override)

compiler/rustc_typeck/src/check/method/suggest.rs

clubby789 · 2022-09-18T23:57:42Z

I notice that even when the type is known and this isn't an issue (e.g)

fn main() {
        let b = Box::new("abc");
        let ptr = b.into_raw();
}

Applying the fix results in incorrect code: Box::<&str>::into_raw()
Should the fix instead transform this to Box::<&str>::into_raw(b)?

compiler/rustc_typeck/src/check/method/suggest.rs

compiler-errors · 2022-09-23T02:03:39Z

Should the fix instead transform this to Box::<&str>::into_raw(b)?

I think so, yes.

clubby789 · 2022-09-23T15:41:41Z

Currently working on automatically adjusting the arguments, but not sure how to handle the case of

struct GenericAssocMethod<T>(T);
impl<T> GenericAssocMethod<T> {
  fn default_hello() {}
}
let x = GenericAssocMethod(33);
x.default_hello();

Where the generic arguments can't be inferred in the GenericAssocMethod::<_>::default_hello form. Applying this or leaving it results in invalid code which causes cargo to print a bug message.

clubby789 · 2022-09-23T16:15:21Z

I've temporarily commented out the problematic test case since this seems like incorrect behaviour from Cargo

compiler-errors · 2022-09-25T23:09:46Z

src/test/ui/suggestions/suggest-assoc-fn-call-with-turbofish.fixed

+fn main() {
+    // Test for inferred types
+    let x = GenericAssocMethod(33);
+    // This particular case is unfixable without more information by the user,


Can you be explicit about needing more information? If this isn't a MachineApplicable diagnostic, then it shouldn't be marked MachineApplicable I think.

The case of x.default_hello() (or any case where the type can't be inferred) emits a HasPlaceholders diagnostic and suggests GenericAssocMethod::<_>::default_hello()

compiler-errors · 2022-09-25T23:11:02Z

Where the generic arguments can't be inferred in the GenericAssocMethod::<_>::default_hello form. Applying this or leaving it results in invalid code which causes cargo to print a bug message.

Then this suggestion should probably not be MachineApplicable, and we shouldn't have a test case that has // run-rustfix for it, but just a regular error test case for it.

compiler-errors · 2022-09-25T23:12:12Z

Marking this as S-waiting-on-author so it can be adjusted to make it not MachineApplicable if it doesn't actually fit the criteria for MachineApplicable, namely that it should produce code that compiles when applied.

compiler/rustc_typeck/src/check/method/suggest.rs

bors · 2022-09-27T14:02:19Z

☔ The latest upstream changes (presumably #102306) made this pull request unmergeable. Please resolve the merge conflicts.

clubby789 · 2022-09-28T13:13:14Z

@rustbot label -S-waiting-on-author +S-waiting-on-review

bors · 2022-10-10T12:18:14Z

☔ The latest upstream changes (presumably #102875) made this pull request unmergeable. Please resolve the merge conflicts.

rustbot · 2022-10-10T12:29:29Z

Some changes occurred in src/tools/cargo

cc @ehuss

clubby789 · 2022-10-10T12:31:36Z

🤔 Sorry about the ping, I think I might have made a mistake while rebasing

bors · 2022-10-21T13:19:48Z

☔ The latest upstream changes (presumably #103310) made this pull request unmergeable. Please resolve the merge conflicts.

bors · 2022-11-04T22:58:34Z

☔ The latest upstream changes (presumably #103978) made this pull request unmergeable. Please resolve the merge conflicts.

compiler-errors · 2022-11-08T18:29:27Z

@bors r+

compiler-errors · 2022-11-10T01:09:50Z

Why didn't bors respond, lol

@bors r+

bors · 2022-11-10T01:09:52Z

📌 Commit 7df4b0b has been approved by compiler-errors

It is now in the queue for this repository.

bors · 2022-11-10T02:05:41Z

⌛ Testing commit 7df4b0b with merge 5eef9b2...

bors · 2022-11-10T04:48:07Z

☀️ Test successful - checks-actions
Approved by: compiler-errors
Pushing 5eef9b2 to master...

bors · 2022-11-10T04:48:07Z

☀️ Test successful - checks-actions
Approved by: compiler-errors
Pushing 5eef9b2 to master...

rust-timer · 2022-11-10T06:06:58Z

Finished benchmarking commit (5eef9b2): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	1.2%	[1.2%, 1.2%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.6%	[-3.5%, -1.3%]	3
All ❌✅ (primary)	-	-	0

Cycles

This benchmark run did not return any relevant results for this metric.

…lder-method, r=compiler-errors Fix auto-application of associated generic functions with placeholders Fixes rust-lang#101920

rust-highfive assigned compiler-errors Sep 18, 2022

rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Sep 18, 2022

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 18, 2022

fmease reviewed Sep 18, 2022

View reviewed changes

compiler/rustc_typeck/src/check/method/suggest.rs Outdated Show resolved Hide resolved

compiler/rustc_typeck/src/check/method/suggest.rs Outdated Show resolved Hide resolved

clubby789 changed the title ~~Prevent auto-application of associated functions with placeholders~~ Fix auto-application of associated generic functions with placeholders Sep 22, 2022

compiler-errors reviewed Sep 23, 2022

View reviewed changes

compiler/rustc_typeck/src/check/method/suggest.rs Outdated Show resolved Hide resolved

compiler-errors reviewed Sep 25, 2022

View reviewed changes

compiler-errors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 25, 2022

compiler-errors reviewed Sep 25, 2022

View reviewed changes

compiler/rustc_typeck/src/check/method/suggest.rs Outdated Show resolved Hide resolved

clubby789 force-pushed the dont-machine-apply-placeholder-method branch from 40c6828 to 45f61a2 Compare September 27, 2022 14:24

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 28, 2022

clubby789 force-pushed the dont-machine-apply-placeholder-method branch from 45f61a2 to 6851f75 Compare October 10, 2022 12:29

clubby789 force-pushed the dont-machine-apply-placeholder-method branch from 6851f75 to f490cff Compare October 10, 2022 13:05

This comment has been minimized.

Sign in to view

clubby789 force-pushed the dont-machine-apply-placeholder-method branch from 5a19cb1 to 6686074 Compare October 23, 2022 12:16

compiler-errors mentioned this pull request Oct 27, 2022

Unhelpful help when calling associated trait function as method #103646

Closed

clubby789 added 9 commits November 5, 2022 22:56

Prevent auto-application of associated functions with placeholders

87de9bd

Allow inferring generic arguments for associated methods

a3b5ca7

Update UI test

d1ec75d

Use FmtPrinter instead of creating Instance

02025b5

Attempt to fix arguments of associated functions

da588e6

Split non-fixable case to different test

cef19b8

Replace boxed iterator with vec collect

2553a95

Update UI test

7e38c8a

Rebase and update test

7df4b0b

clubby789 force-pushed the dont-machine-apply-placeholder-method branch from 6686074 to 7df4b0b Compare November 5, 2022 23:08

compiler-errors approved these changes Nov 8, 2022

View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 10, 2022

bors added the merged-by-bors This PR was explicitly merged by bors. label Nov 10, 2022

bors merged commit 5eef9b2 into rust-lang:master Nov 10, 2022

rustbot added this to the 1.67.0 milestone Nov 10, 2022

jruderman mentioned this pull request Nov 14, 2022

ICE: [DefId for associated constant] does not have a "fn_sig" #104412

Closed

clubby789 deleted the dont-machine-apply-placeholder-method branch February 11, 2023 14:42

Fix auto-application of associated generic functions with placeholders #101990

Fix auto-application of associated generic functions with placeholders #101990

Uh oh!

Conversation

clubby789 commented Sep 18, 2022

Uh oh!

rust-highfive commented Sep 18, 2022

Uh oh!

Uh oh!

Uh oh!

clubby789 commented Sep 18, 2022

Uh oh!

Uh oh!

compiler-errors commented Sep 23, 2022

Uh oh!

clubby789 commented Sep 23, 2022

Uh oh!

clubby789 commented Sep 23, 2022

Uh oh!

compiler-errors Sep 25, 2022

Choose a reason for hiding this comment

Uh oh!

clubby789 Sep 25, 2022

Choose a reason for hiding this comment

Uh oh!

compiler-errors commented Sep 25, 2022

Uh oh!

compiler-errors commented Sep 25, 2022

Uh oh!

Uh oh!

bors commented Sep 27, 2022

Uh oh!

clubby789 commented Sep 28, 2022

Uh oh!

bors commented Oct 10, 2022

Uh oh!

rustbot commented Oct 10, 2022

Uh oh!

clubby789 commented Oct 10, 2022

Uh oh!

This comment has been minimized.

bors commented Oct 21, 2022

Uh oh!

bors commented Nov 4, 2022

Uh oh!

compiler-errors commented Nov 8, 2022

Uh oh!

compiler-errors commented Nov 10, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bors commented Nov 10, 2022

Uh oh!

bors commented Nov 10, 2022

Uh oh!

bors commented Nov 10, 2022

Uh oh!

bors commented Nov 10, 2022

Uh oh!

rust-timer commented Nov 10, 2022

Overall result: ❌ regressions - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Uh oh!

Uh oh!

compiler-errors commented Nov 10, 2022 •

edited

Loading