Skip to content

Suggest associated const for incorrect use of let in traits #101843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 16, 2022
Merged

Suggest associated const for incorrect use of let in traits #101843

merged 2 commits into from
Sep 16, 2022

Conversation

chenyukang
Copy link
Member

Fixes #101797

@rust-highfive
Copy link
Contributor

r? @oli-obk

(rust-highfive has picked a reviewer for you, use r? to override)

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Sep 15, 2022
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 15, 2022
Rageking8
Rageking8 reviewed Sep 15, 2022
View reviewed changes
@oli-obk
Copy link
Contributor

oli-obk commented Sep 15, 2022

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Sep 15, 2022

📌 Commit 98e20c0 has been approved by oli-obk

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 15, 2022
@oli-obk
Copy link
Contributor

oli-obk commented Sep 15, 2022

@bors r- review race condition

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 15, 2022
@Rageking8
Copy link
Contributor

Rageking8 commented Sep 15, 2022 •
edited
Loading

Haha 😂😂.

The timing...

@oli-obk
Copy link
Contributor

oli-obk commented Sep 16, 2022

@bors r+ rollup

Thanks both of you! :)

@bors
Copy link
Collaborator

bors commented Sep 16, 2022

📌 Commit 4bf7d2c has been approved by oli-obk

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 16, 2022
@GuillaumeGomez GuillaumeGomez mentioned this pull request Sep 16, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 16, 2022
@bors
Auto merge of rust-lang#101895 - GuillaumeGomez:rollup-ured85q, r=Gui…
54f20bb 
…llaumeGomez

Rollup of 7 pull requests

Successful merges:

 - rust-lang#101494 (rustdoc mobile: move notable traits to return type)
 - rust-lang#101813 (Extend CSS check to CSS variables)
 - rust-lang#101825 (Fix back RPIT changes)
 - rust-lang#101843 (Suggest associated const for incorrect use of let in traits)
 - rust-lang#101859 (Slight vertical formatting)
 - rust-lang#101868 (rustdoc: use more precise URLs for jump-to-definition links)
 - rust-lang#101877 (rustdoc: remove no-op CSS `.block { padding: 0 }`)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 72d9e08 into rust-lang:master Sep 16, 2022
@rustbot rustbot added this to the 1.65.0 milestone Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@Rageking8 Rageking8 Rageking8 left review comments

Reviewers whose approvals may not affect merge requirements
Assignees

@oli-obk oli-obk

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.65.0
Development

Successfully merging this pull request may close these issues.

Suggest associated const for incorrect use of let in traits
6 participants
@chenyukang @rust-highfive @oli-obk @bors @Rageking8 @rustbot