Fix LLVM IR type mismatch reported in #99551

[crlf0710]

Closes #99551 .

[rust-highfive]

r? @Mark-Simulacrum

(rust-highfive has picked a reviewer for you, use r? to override)

[crlf0710]

r? @bjorn3

[bjorn3]

r=me once CI passes

[bjorn3]

failures:

---- [ui] src/test/ui/traits/trait-upcasting/replace-vptr.rs stdout ----

error: test compilation failed although it shouldn't!
status: exit status: 101
command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/traits/trait-upcasting/replace-vptr.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "-O" "--error-format" "json" "--json" "future-incompat" "-Ccodegen-units=1" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "-Cstrip=debuginfo" "-C" "prefer-dynamic" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/traits/trait-upcasting/replace-vptr/a" "-Crpath" "-Cdebuginfo=0" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/traits/trait-upcasting/replace-vptr/auxiliary"
stdout: none
--- stderr -------------------------------
Use of instruction is not an instruction!
  %5 = load i8*, i8** %4, align 8, !invariant.load !4, !nonnull !4
LLVM ERROR: Broken module found, compilation aborted!
------------------------------------------


---- [ui] src/test/ui/traits/trait-upcasting/correct-supertrait-substitution.rs stdout ----

error: test compilation failed although it shouldn't!
status: exit status: 101
command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/traits/trait-upcasting/correct-supertrait-substitution.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "-O" "--error-format" "json" "--json" "future-incompat" "-Ccodegen-units=1" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "-Cstrip=debuginfo" "-C" "prefer-dynamic" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/traits/trait-upcasting/correct-supertrait-substitution/a" "-Crpath" "-Cdebuginfo=0" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/traits/trait-upcasting/correct-supertrait-substitution/auxiliary"
stdout: none
--- stderr -------------------------------
Use of instruction is not an instruction!
  %78 = load i8*, i8** %77, align 8, !invariant.load !4, !nonnull !4
LLVM ERROR: Broken module found, compilation aborted!
------------------------------------------


---- [ui] src/test/ui/traits/trait-upcasting/diamond.rs stdout ----

error: test compilation failed although it shouldn't!
status: exit status: 101
command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/traits/trait-upcasting/diamond.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "-O" "--error-format" "json" "--json" "future-incompat" "-Ccodegen-units=1" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "-Cstrip=debuginfo" "-C" "prefer-dynamic" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/traits/trait-upcasting/diamond/a" "-Crpath" "-Cdebuginfo=0" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/traits/trait-upcasting/diamond/auxiliary"
stdout: none
--- stderr -------------------------------
Use of instruction is not an instruction!
  %379 = load i8*, i8** getelementptr inbounds (i8*, i8** getelementptr inbounds (<{ i8*, [16 x i8], i8*, i8*, i8*, i8*, i8*, i8*, i8*, i8*, i8*, i8*, i8*, i8*, i8*, i8*, i8* }>, <{ i8*, [16 x i8], i8*, i8*, i8*, i8*, i8*, i8*, i8*, i8*, i8*, i8*, i8*, i8*, i8*, i8*, i8* }>* @10, i32 0, i32 0), i64 16), align 8, !invariant.load !4, !nonnull !4
LLVM ERROR: Broken module found, compilation aborted!
------------------------------------------



failures:
    [ui] src/test/ui/traits/trait-upcasting/correct-supertrait-substitution.rs
    [ui] src/test/ui/traits/trait-upcasting/diamond.rs
    [ui] src/test/ui/traits/trait-upcasting/replace-vptr.rs

[bjorn3]

@bors r+

[bors]

📌 Commit 1cbbd2a has been approved by bjorn3

It is now in the queue for this repository.

[bors]

⌛ Testing commit 1cbbd2a with merge 4a6ac3c...

[bors]

☀️ Test successful - checks-actions
Approved by: bjorn3
Pushing 4a6ac3c to master...

[rust-timer]

Finished benchmarking commit (4a6ac3c): comparison URL.

Overall result: ❌ regressions - ACTION NEEDED

Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please open an issue or create a new PR that fixes the regressions, add a comment linking to the newly created issue or PR, and then add the perf-regression-triaged label to this PR.

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean1	range	count2
Regressions ❌ (primary)	1.3%	[1.3%, 1.3%]	1
Regressions ❌ (secondary)	3.4%	[3.1%, 3.9%]	6
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	1.3%	[1.3%, 1.3%]	1

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean1	range	count2
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.5%	[0.5%, 0.5%]	1
Improvements ✅ (primary)	-4.3%	[-4.3%, -4.3%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-4.3%	[-4.3%, -4.3%]	1

Cycles

This benchmark run did not return any relevant results for this metric.

Footnotes

1. the arithmetic mean of the percent change ↩ ↩²

2. number of relevant changes ↩ ↩²

[nnethercote]

cranelift-codegen and keccak have been noisy lately.

@rustbot label: +perf-regression-triaged