- 
                Notifications
    You must be signed in to change notification settings 
- Fork 13.9k
          Allow lint passes to be bound by TyCtxt
          #101501
        
          New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
    
                
     Merged
            
            
          Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    | Some changes occurred in src/tools/clippy cc @rust-lang/clippy | 
              
                    camsteffen
  
              
              reviewed
              
                  
                    Sep 6, 2022 
                  
              
              
            
            
              
                    davidtwco
  
              
              approved these changes
              
                  
                    Sep 7, 2022 
                  
              
              
            
            
| @bors r+ | 
    
  Dylan-DPC 
      added a commit
        to Dylan-DPC/rust
      that referenced
      this pull request
    
      Sep 8, 2022 
    
    
      
  
    
      
    
  
Allow lint passes to be bound by `TyCtxt` This will allow storing things like `Ty<'tcx>` inside late lint passes. It's already possible to store various id types so they're already implicitly bound to a specific `TyCtxt`. r? rust-lang/compiler
    
  Dylan-DPC 
      added a commit
        to Dylan-DPC/rust
      that referenced
      this pull request
    
      Sep 8, 2022 
    
    
      
  
    
      
    
  
Allow lint passes to be bound by `TyCtxt` This will allow storing things like `Ty<'tcx>` inside late lint passes. It's already possible to store various id types so they're already implicitly bound to a specific `TyCtxt`. r? rust-lang/compiler
  This was referenced Sep 8, 2022 
      
    
  bors 
      added a commit
        to rust-lang-ci/rust
      that referenced
      this pull request
    
      Sep 8, 2022 
    
    
      
  
    
      
    
  
Rollup of 7 pull requests Successful merges: - rust-lang#98933 (Opaque types' generic params do not imply anything about their hidden type's lifetimes) - rust-lang#101041 (translations(rustc_session): migrates rustc_session to use SessionDiagnostic - Pt. 2) - rust-lang#101424 (Adjust and slightly generalize operator error suggestion) - rust-lang#101496 (Allow lower_lifetime_binder receive a closure) - rust-lang#101501 (Allow lint passes to be bound by `TyCtxt`) - rust-lang#101515 (Recover from typo where == is used in place of =) - rust-lang#101545 (Remove unnecessary `PartialOrd` and `Ord`) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
    
  smoelius 
      added a commit
        to trailofbits/dylint
      that referenced
      this pull request
    
      Oct 2, 2022 
    
    
      
  
    
      
    
  
And add `boundary_toolchains` test
    
  smoelius 
      added a commit
        to trailofbits/dylint
      that referenced
      this pull request
    
      Oct 2, 2022 
    
    
      
  
    
      
    
  
And add `boundary_toolchains` test
    
  smoelius 
      added a commit
        to trailofbits/dylint
      that referenced
      this pull request
    
      Oct 2, 2022 
    
    
      
  
    
      
    
  
And add `boundary_toolchains` test
    
  flip1995 
      pushed a commit
        to flip1995/rust
      that referenced
      this pull request
    
      Oct 6, 2022 
    
    
      
  
    
      
    
  
Allow lint passes to be bound by `TyCtxt` This will allow storing things like `Ty<'tcx>` inside late lint passes. It's already possible to store various id types so they're already implicitly bound to a specific `TyCtxt`. r? rust-lang/compiler
    
  flip1995 
      pushed a commit
        to flip1995/rust
      that referenced
      this pull request
    
      Oct 6, 2022 
    
    
      
  
    
      
    
  
Rollup of 7 pull requests Successful merges: - rust-lang#98933 (Opaque types' generic params do not imply anything about their hidden type's lifetimes) - rust-lang#101041 (translations(rustc_session): migrates rustc_session to use SessionDiagnostic - Pt. 2) - rust-lang#101424 (Adjust and slightly generalize operator error suggestion) - rust-lang#101496 (Allow lower_lifetime_binder receive a closure) - rust-lang#101501 (Allow lint passes to be bound by `TyCtxt`) - rust-lang#101515 (Recover from typo where == is used in place of =) - rust-lang#101545 (Remove unnecessary `PartialOrd` and `Ord`) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
    
  yvt 
      added a commit
        to yvt/servo
      that referenced
      this pull request
    
      Oct 16, 2022 
    
    
      
  
    
      
    
  
…tra arg to a given closure <rust-lang/rust#101501>
    
  yvt 
      added a commit
        to yvt/servo
      that referenced
      this pull request
    
      Oct 16, 2022 
    
    
      
  
    
      
    
  
…tra arg to a given closure <rust-lang/rust#101501>
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      Labels
      
    S-waiting-on-bors
  Status: Waiting on bors to run and complete tests. Bors will change the label on completion. 
  
    T-compiler
  Relevant to the compiler team, which will review and decide on the PR/issue. 
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
This will allow storing things like
Ty<'tcx>inside late lint passes. It's already possible to store various id types so they're already implicitly bound to a specificTyCtxt.r? rust-lang/compiler