Do not report too many expr field candidates #100898
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
T-compiler
|
r? @spastorino (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
compiler-errors
force-pushed
the
too-many-expr-fields
branch
from
64333ed to
d669eca
Compare
compiler-errors
commented
Aug 23, 2022
|
@rustbot author |
rustbot
added
S-waiting-on-author
compiler-errors
force-pushed
the
too-many-expr-fields
branch
from
d669eca to
0a3b08a
Compare
|
@rustbot ready |
rustbot
added
S-waiting-on-review
spastorino
reviewed
Aug 25, 2022
compiler-errors
force-pushed
the
too-many-expr-fields
branch
from
0a3b08a to
c3f568b
Compare
compiler-errors
commented
Aug 25, 2022
| | +++ | ||
| LL | t.a3.bar(); | ||
| | +++ | ||
| and 6 other candidates |
|
@bors r+ |
bors
added
S-waiting-on-bors
Dylan-DPC
added a commit
to Dylan-DPC/rust
that referenced
this pull request
Aug 27, 2022
…ds, r=spastorino
Do not report too many expr field candidates
When considering "this expressions' field has a {field/method}" suggestions:
1. Don't report methods that are out of scope
2. Use `span_suggestions` instead of reporting each field candidate, which caps the number of suggestions to 4
4. Blacklist some common traits like `Clone` and `Deref`
Fixes rust-lang#100894
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Aug 28, 2022
…ds, r=spastorino
Do not report too many expr field candidates
When considering "this expressions' field has a {field/method}" suggestions:
1. Don't report methods that are out of scope
2. Use `span_suggestions` instead of reporting each field candidate, which caps the number of suggestions to 4
4. Blacklist some common traits like `Clone` and `Deref`
Fixes rust-lang#100894
This was referenced Aug 28, 2022
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 29, 2022
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#100898 (Do not report too many expr field candidates) - rust-lang#101056 (Add the syntax of references to their documentation summary.) - rust-lang#101106 (Rustdoc-Json: Retain Stripped Modules when they are imported, not when they have items) - rust-lang#101131 (CTFE: exposing pointers and calling extern fn is just impossible) - rust-lang#101141 (Simplify `get_trait_ref` fn used for `virtual_function_elimination`) - rust-lang#101146 (Various changes to logging of borrowck-related code) - rust-lang#101156 (Remove `Sync` requirement from lint pass objects) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Jan 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When considering "this expressions' field has a {field/method}" suggestions:
span_suggestionsinstead of reporting each field candidate, which caps the number of suggestions to 4CloneandDerefFixes #100894