Coherence negative impls implied bounds #100888
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
T-compiler
rust-highfive
added
the
S-waiting-on-review
spastorino
force-pushed
the
coherence-negative-impls-implied-bounds
branch
from
3cd2502 to
c66ef3f
Compare
|
Rebased on top of #99702 which has removed |
lcnr
reviewed
Aug 23, 2022
|
☔ The latest upstream changes (presumably #100904) made this pull request unmergeable. Please resolve the merge conflicts. |
spastorino
force-pushed
the
coherence-negative-impls-implied-bounds
branch
from
c66ef3f to
4da14ef
Compare
|
Rebased on top of master as #100789 is already merged, so this is now ready. |
bors
added
S-waiting-on-bors
|
@bors rollup |
nikomatsakis
approved these changes
Aug 24, 2022
|
Looks like lcnr already reviewed, but r+ from me, too. |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 24, 2022
…iaskrgr Rollup of 15 pull requests Successful merges: - rust-lang#99993 (linker: Update some outdated comments) - rust-lang#100220 (Properly forward `ByRefSized::fold` to the inner iterator) - rust-lang#100826 (sugg: take into count the debug formatting) - rust-lang#100855 (Extra documentation for new formatting feature) - rust-lang#100888 (Coherence negative impls implied bounds) - rust-lang#100901 (Make some methods private) - rust-lang#100906 (Suggest alternatives when trying to mutate a `HashMap`/`BTreeMap` via indexing) - rust-lang#100912 (Diagnose missing includes in run-make tests) - rust-lang#100919 (Use par_body_owners for liveness) - rust-lang#100922 (Rewrite error index generator to greatly reduce the size of the pages) - rust-lang#100926 (Update README.md) - rust-lang#100930 (Use `--userns=keep-id` when "docker" is really podman) - rust-lang#100938 (rustdoc: remove unused CSS rule) - rust-lang#100940 (Do not suggest adding a bound to a opaque type) - rust-lang#100945 (Add a missing test case for impl generic mismatch) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #93875
This PR is rebased on top of #100789 and it would need to include that one which is already r+ed.
r? @nikomatsakis
cc @lcnr (which I've talked about 3222f42, I guess after you finish your reordering of modules and work with OutlivesEnvironmentEnv this commit can just be reverted).