- 
                Notifications
    You must be signed in to change notification settings 
- Fork 13.9k
          Migrate rustc_mir_build diagnostics
          #100854
        
          New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @estebank (or someone else) soon. Please see the contribution instructions for more information. | 
      
        
              This comment has been minimized.
        
        
      
    
  This comment has been minimized.
9b7b2cf    to
    fc79d28      
    Compare
  
    | r? @davidtwco | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me, one question..
b7d514f    to
    ed1e9bb      
    Compare
  
    | Use  | 
b2fa07a    to
    bed1132      
    Compare
  
    
      
        
              This comment has been minimized.
        
        
      
    
  This comment has been minimized.
bed1132    to
    e7a4a79      
    Compare
  
    
      
        
              This comment has been minimized.
        
        
      
    
  This comment has been minimized.
74b15df    to
    c9d8bf6      
    Compare
  
    
      
        
              This comment has been minimized.
        
        
      
    
  This comment has been minimized.
ad407f2    to
    3a1e207      
    Compare
  
    There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still looks good, I assume you're still working on it as the PR is a draft, nice work!
| Thank you, and yes I'm still working actively on this. There are more pattern diagnostics than I imagined at first. Also I've been committing most diagnostics separately, should I squash them or keep them this way? | 
| 
 Either is fine :) | 
      
        
              This comment has been minimized.
        
        
      
    
  This comment has been minimized.
0e1dd82    to
    5cb7e4f      
    Compare
  
    
      
        
              This comment has been minimized.
        
        
      
    
  This comment has been minimized.
5cb7e4f    to
    3e527aa      
    Compare
  
    | I've hit a problem where the most recent subdiagnostic's arguments "shadow" the previous ones (this was previously mentioned in Zulip) while migrating  | 
| The job  Click to see the possible cause of the failure (guessed by this bot) | 
| ☔ The latest upstream changes (presumably #101479) made this pull request unmergeable. Please resolve the merge conflicts. | 
| 
 We'll just need to leave this untranslated for now, I'm afraid, so feel free to skip them and leave  | 
| Oh, and apologies for the delay in responding, don't know how I managed to miss this one for six days. | 
| It happens, I'll quickly resolve everything then | 
| Hi, I've seen you changed some diagnostic structs in your PR. After #103345, the way we refer to fluent messages changed. They are now in a flat namespace with the same identifier as in the fluent file. For example,   | 
| @AsyaTheAbove are you still able to work on this? | 
| 
 not really, I've been busy recently and even when I do get to work on it I have a few issues with my development environment that I've been struggling with | 
| Does this only need a rebase? It seems good to go otherwise. | 
| Closing in favour of #104417. | 
Migrate rustc_mir_build diagnostics Rebases rust-lang#100854 ~~The remaining issue is how to better resolve rust-lang@72bea68af4ee2a41c44998916f6a789163f12e7d~~ ~~The diagnostic macros seems to generate a broken diagnostic, and I couldn't figure out how to manually format the fluent message, so I hardcoded the format string for now. I'd like pointers to a better fix for this.~~ Also, I'm not 100% sure I didn't mess up a rebase somewhere 🙂 r? `@davidtwco`
Migrate rustc_mir_build diagnostics Rebases rust-lang#100854 ~~The remaining issue is how to better resolve rust-lang@72bea68af4ee2a41c44998916f6a789163f12e7d~~ ~~The diagnostic macros seems to generate a broken diagnostic, and I couldn't figure out how to manually format the fluent message, so I hardcoded the format string for now. I'd like pointers to a better fix for this.~~ Also, I'm not 100% sure I didn't mess up a rebase somewhere 🙂 r? `@davidtwco`
Migrate rustc_mir_build diagnostics Rebases rust-lang#100854 ~~The remaining issue is how to better resolve rust-lang@72bea68af4ee2a41c44998916f6a789163f12e7d~~ ~~The diagnostic macros seems to generate a broken diagnostic, and I couldn't figure out how to manually format the fluent message, so I hardcoded the format string for now. I'd like pointers to a better fix for this.~~ Also, I'm not 100% sure I didn't mess up a rebase somewhere 🙂 r? ``@davidtwco``
Migrate rustc_mir_build diagnostics Rebases rust-lang#100854 ~~The remaining issue is how to better resolve rust-lang@72bea68af4ee2a41c44998916f6a789163f12e7d~~ ~~The diagnostic macros seems to generate a broken diagnostic, and I couldn't figure out how to manually format the fluent message, so I hardcoded the format string for now. I'd like pointers to a better fix for this.~~ Also, I'm not 100% sure I didn't mess up a rebase somewhere 🙂 r? ```@davidtwco```
Migrate rustc_mir_build diagnostics Rebases rust-lang#100854 ~~The remaining issue is how to better resolve rust-lang@72bea68af4ee2a41c44998916f6a789163f12e7d~~ ~~The diagnostic macros seems to generate a broken diagnostic, and I couldn't figure out how to manually format the fluent message, so I hardcoded the format string for now. I'd like pointers to a better fix for this.~~ Also, I'm not 100% sure I didn't mess up a rebase somewhere 🙂 r? `@davidtwco`
This PR migrates
rustc_mir_buildto use translatable diagnostics@rustbot label +A-translation
r? rust-lang/diagnostics