Skip to content

Migrate rustc_ty_utils to SessionDiagnostic #100735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 27, 2022
Merged

Migrate rustc_ty_utils to SessionDiagnostic #100735

merged 1 commit into from
Aug 27, 2022
+208 −94

Conversation

Facel3ss1
Copy link
Contributor

I have migrated the rustc_ty_utils crate to use SessionDiagnostic, motivated by the recent blog post about the diagnostic translation effort.

This is my first PR to the Rust repository, so if I have missed anything, or anything needs to be changed, please let me know! 😄

@rustbot label +A-translation

@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @fee1-dead (or someone else) soon.

Please see the contribution instructions for more information.

@rustbot rustbot added A-translation Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 18, 2022
@rustbot
Copy link
Collaborator

rustbot commented Aug 18, 2022

rustc_error_messages was changed

cc @davidtwco, @compiler-errors, @JohnTitor, @estebank

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 18, 2022
@fee1-dead
Copy link
Member

r? @davidtwco

@rust-highfive rust-highfive assigned davidtwco and unassigned fee1-dead Aug 19, 2022
davidtwco
davidtwco reviewed Aug 19, 2022
View reviewed changes
@davidtwco
Copy link
Member

@bors r+

@bors
Copy link
Collaborator

bors commented Aug 19, 2022

📌 Commit c817dc30cfd464a8a1e3121d2dcd06a61be1461f has been approved by davidtwco

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 19, 2022
@davidtwco
Copy link
Member

@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 19, 2022
@Facel3ss1 Facel3ss1 force-pushed the ty-utils-translation branch from c817dc3 to 8028ec1 Compare August 19, 2022 10:56
@Facel3ss1
Copy link
Contributor Author

I have moved the deny attributes to the root of the crate

@davidtwco davidtwco mentioned this pull request Aug 19, 2022
Open
84 tasks
@davidtwco
Copy link
Member

@bors r+

@bors
Copy link
Collaborator

bors commented Aug 19, 2022

📌 Commit 8028ec186e8dcb583c6e9740e26863378da5d0dd has been approved by davidtwco

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 19, 2022
@bors

This comment was marked as resolved.

Sign in to view
@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 22, 2022
@Facel3ss1 Facel3ss1 force-pushed the ty-utils-translation branch from 8028ec1 to 2957815 Compare August 22, 2022 15:23
@bors
Copy link
Collaborator

bors commented Aug 22, 2022

📌 Commit 7affbb0f163f24033161ae38c8038cf667c20282 has been approved by davidtwco

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 22, 2022
@bors

This comment was marked as resolved.

Sign in to view
@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 25, 2022
@davidtwco
Copy link
Member

Re-request a review once you've resolved the conflicts so that I can re-approve.

@Facel3ss1 Facel3ss1 force-pushed the ty-utils-translation branch from 7affbb0 to 7754ab1 Compare August 25, 2022 22:33
@Facel3ss1
Copy link
Contributor Author

r? @davidtwco

@davidtwco
Copy link
Member

@bors r+

@bors
Copy link
Collaborator

bors commented Aug 26, 2022

📌 Commit 7754ab1441b43663ddbf3fa576ad75d0c744d475 has been approved by davidtwco

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 26, 2022
@bors

This comment was marked as resolved.

Sign in to view
@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 26, 2022
@Facel3ss1 Facel3ss1 force-pushed the ty-utils-translation branch from 7754ab1 to 01c1616 Compare August 26, 2022 14:03
@Facel3ss1
Copy link
Contributor Author

Fixed some more merge conficts

r? @davidtwco

@davidtwco
Copy link
Member

@bors r+

@bors
Copy link
Collaborator

bors commented Aug 26, 2022

📌 Commit 01c1616 has been approved by davidtwco

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 26, 2022
@compiler-errors
Copy link
Member

@bors rollup

@compiler-errors compiler-errors mentioned this pull request Aug 26, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 27, 2022
@bors
Auto merge of rust-lang#101064 - compiler-errors:rollup-fwm5m5f, r=co…
bb8a08f 
…mpiler-errors

Rollup of 9 pull requests

Successful merges:

 - rust-lang#100724 (Migrate ast lowering to session diagnostic)
 - rust-lang#100735 (Migrate `rustc_ty_utils` to `SessionDiagnostic`)
 - rust-lang#100738 (Diagnostics migr const eval)
 - rust-lang#100744 (Migrate rustc_mir_dataflow to diagnostic structs)
 - rust-lang#100776 (Migrate `rustc_lint` errors to `SessionDiagnostic`)
 - rust-lang#100817 (sugg: suggest the usage of boolean value when there is a typo in the keyword)
 - rust-lang#100836 (Migrate `rustc_attr` crate diagnostics)
 - rust-lang#100890 (Migrate rustc_driver to SessionDiagnostic)
 - rust-lang#100900 (on `region_errors.rs`)

Failed merges:

 - rust-lang#100831 (Migrate `symbol_mangling` module to new diagnostics structs)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 181b041 into rust-lang:master Aug 27, 2022
@rustbot rustbot added this to the 1.65.0 milestone Aug 27, 2022
@Facel3ss1 Facel3ss1 deleted the ty-utils-translation branch August 27, 2022 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidtwco davidtwco davidtwco approved these changes

@estebank estebank estebank approved these changes

Assignees

@davidtwco davidtwco

Labels
A-translation Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.65.0
Development

Successfully merging this pull request may close these issues.
8 participants
@Facel3ss1 @rust-highfive @rustbot @fee1-dead @davidtwco @bors @compiler-errors @estebank