Rename Machine memory hooks to suggest when they run #100600
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Some changes occurred to the CTFE / Miri engine cc @rust-lang/miri |
rustbot
added
the
T-compiler
|
r? @davidtwco (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
r? @RalfJung |
|
Uh, what happened with CI? |
|
r=me when CI is green |
|
✌️ @saethlin can now approve this pull request |
|
Hm let's see if I just amend with no changes and force-push... |
saethlin
force-pushed
the
rename-memory-hooks
branch
from
1f36517 to
a5cc3a0
Compare
|
It's a general CI problem currently, nothing wrong with this PR. So I'll just trust that you did a check-build locally... |
bors
added
S-waiting-on-bors
|
Yes the PR passes |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 16, 2022
…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#100338 (when there are 3 or more return statements in the loop) - rust-lang#100384 (Add support for generating unique profraw files by default when using `-C instrument-coverage`) - rust-lang#100460 (Update the minimum external LLVM to 13) - rust-lang#100567 (Add missing closing quote) - rust-lang#100590 (Suggest adding an array length if possible) - rust-lang#100600 (Rename Machine memory hooks to suggest when they run) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
bors
added a commit
to rust-lang/miri
that referenced
this pull request
Aug 16, 2022
Rename memory hooks Companion to rust-lang/rust#100600
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the other memory hooks start with
before_orafter_to indicate that they run before or after a certain operation. These don't, so I was a bit confused as to when they are supposed to run.memory_readcan be read two ways in English, "memory was read" or "this is a memory read" so without the prefix this was especially ambiguous.