Skip to content

Conversation

nicholasbishop
Copy link
Contributor

@nicholasbishop nicholasbishop commented Aug 7, 2022

Among other things, this pulls in rust-lang/compiler-builtins#475, which fixes some i128/u128 arithmetic operations on the x86_64-unknown-uefi target.

@rust-highfive
Copy link
Contributor

r? @Mark-Simulacrum

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 7, 2022
@Mark-Simulacrum
Copy link
Member

@bors r+ rollup=never

@bors
Copy link
Collaborator

bors commented Aug 7, 2022

📌 Commit 3c43203 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 7, 2022
@bors
Copy link
Collaborator

bors commented Aug 7, 2022

⌛ Testing commit 3c43203 with merge d394408...

@bors
Copy link
Collaborator

bors commented Aug 7, 2022

☀️ Test successful - checks-actions
Approved by: Mark-Simulacrum
Pushing d394408 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 7, 2022
@bors bors merged commit d394408 into rust-lang:master Aug 7, 2022
@rustbot rustbot added this to the 1.65.0 milestone Aug 7, 2022
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (d394408): comparison url.

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results
  • Primary benchmarks: 🎉 relevant improvement found
  • Secondary benchmarks: 😿 relevant regression found
mean1 max count2
Regressions 😿
(primary)
N/A N/A 0
Regressions 😿
(secondary)
2.0% 2.0% 1
Improvements 🎉
(primary)
-3.4% -3.4% 1
Improvements 🎉
(secondary)
N/A N/A 0
All 😿🎉 (primary) -3.4% -3.4% 1

Cycles

Results
  • Primary benchmarks: mixed results
  • Secondary benchmarks: 😿 relevant regression found
mean1 max count2
Regressions 😿
(primary)
2.1% 2.1% 1
Regressions 😿
(secondary)
7.0% 7.0% 1
Improvements 🎉
(primary)
-2.1% -2.2% 2
Improvements 🎉
(secondary)
N/A N/A 0
All 😿🎉 (primary) -0.7% -2.2% 3

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

Footnotes

  1. the arithmetic mean of the percent change 2

  2. number of relevant changes 2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants