Remove InferCtxt::commit_unconditionally
#100099
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @cjgillot (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
🤣 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't think we need this anymore...?
I don't have much context, but I was poking around old rust sources for history, and afaict
InferCtxt::commit_unconditionallycame fromInferCtxt::in_snapshot, which was useful because the snapshot variable was used for things likeInferCtxt::plug_leakswhich we don't have anymore.We have only one usage of
InferCtxt::commit_unconditionallywhich does use the snapshot for leak check, but I think that's better served byInferCtxt::commit_if_ok. I think @jackh726 touched that last in #97206.This PR is best reviewed by disabling whitespace in the diff settings.