beta regression: $crate may not be imported

[Mark-Simulacrum]

Number of crates regressed: 26

Looks like essentially all the regressions come from a piston2d-gfx_graphics macro. Bisecting this may be helpful, not sure.

cc @petrochenkov

• ThePianoDentist/rusty-dota-manager
• XavilPergis/rusty-tiles
• bluecereal/a_game
• bluecereal/mvp_transform
• bluecereal/oop_gfx_test
• bluecereal/transform
• bluecereal/using_math_lib
• carols10cents/color-game
• chip8-rust/chip8-ui
• despawnerer/piston-tutorial
• echochamber/rust_spin_wheel
• edigiacomo/snake-rust
• fabiosantoscode/life
• jakmeier/cheer-them-up
• jakmeier/rusty-shortest-path-map-inspector
• jjjjw/rust_elmish_rocket
• kamicut/rust-fractal-experiments
• mattkuo/rusty-chips
• nbez/0.1.0
• pierrechevalier83/mengner
• piston-opengex/0.6.0
• robinwhittleton/life_rs
• shmutalov/tick-tack-toe-killer-rs
• sumproxy/tetris_tmp
• whodidthis/gfx-rs-testing
• yeliknewo/souls

[petrochenkov]

Introduced in #67775 ("Make "use $crate" a hard error ").

[Mark-Simulacrum]

Looks like probably expected breakage -- fallout is not too big, essentially just one root crate. Would be good to figure out if there's a fixed release of said crate that crater didn't pick up, or try to get the crate maintainer to do so. #37390 is the compatibility lint tracking issue.

[pnkfelix]

expected breakage.

I think the main work item here would be to make sure that the crate in question has a version people can upgrade to, so that they can at least address this in response to the 1.42.0 release.

[pnkfelix]

triage: P-high to confirm that there is an upgrade path for piston2d-gfx_graphics (potentially a 0.27.1, or maybe just relying on their existing versions)

[pnkfelix]

Upgrading piston2d-gfx_graphics from 0.27 to 0.30 seems to do the trick.

The actual problem originates in a macro defined in a dependency (the gfx crate itself).

• Its non-trivial to upgrade to the first version of gfx (namely 0.12) that does not exhibit the bug. At the very least, you cannot get away with just changing that line of the Cargo.toml for piston2d-gfx_graphics.
• So, given that there does exist an upgrade path (via gfx_graphics=0.30) and that the most obvious "simpler" solution does not suffice, I'm going to just say the answer here is "upgrade your dependencies to at least gfx_graphics=0.30"

[pnkfelix]

Closing as expected fallout from the conversion to a hard error.