- 
                Notifications
    You must be signed in to change notification settings 
- Fork 13.9k
Closed
Labels
A-diagnosticsArea: Messages for errors, warnings, and lintsArea: Messages for errors, warnings, and lintsE-easyCall for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Description
From: src/test/compile-fail/E0449.rs
E0449 needs a span_label and a span_note changed to a note, updating this:
error[E0449]: unnecessary visibility qualifier
  --> src/test/compile-fail/E0449.rs:17:1
   |
17 | pub impl Bar {} //~ ERROR E0449
   | ^^^^^^^^^^^^^^^
   |
note: place qualifiers on individual impl items instead
  --> src/test/compile-fail/E0449.rs:17:1
   |
17 | pub impl Bar {} //~ ERROR E0449
   | ^^^^^^^^^^^^^^^
To:
error[E0449]: unnecessary visibility qualifier
  --> src/test/compile-fail/E0449.rs:17:1
   |
17 | pub impl Bar {} //~ ERROR E0449
   | ^^^^^^^^^^^^^^^ `pub` not needed here
   |
   = note: place qualifiers on individual impl items instead
Bonus (though not sure if this is reasonable, but would be nice to try): let's underline the pub if we can.
error[E0449]: unnecessary visibility qualifier
  --> src/test/compile-fail/E0449.rs:17:1
   |
17 | pub impl Bar {} //~ ERROR E0449
   | ^^^ `pub` not needed here
   |
   = note: place qualifiers on individual impl items instead
Metadata
Metadata
Assignees
Labels
A-diagnosticsArea: Messages for errors, warnings, and lintsArea: Messages for errors, warnings, and lintsE-easyCall for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.