-
Notifications
You must be signed in to change notification settings - Fork 13.7k
Closed
Labels
A-diagnosticsArea: Messages for errors, warnings, and lintsArea: Messages for errors, warnings, and lintsC-bugCategory: This is a bug.Category: This is a bug.I-ICEIssue: The compiler panicked, giving an Internal Compilation Error (ICE) ❄️Issue: The compiler panicked, giving an Internal Compilation Error (ICE) ❄️T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.Relevant to the compiler team, which will review and decide on the PR/issue.
Description
When building a binary for mac and dsymutil is not in $PATH for whatever reason, this is the message that appears, followed by a backtrace, instead of the intended error:
thread 'rustc' panicked at compiler/rustc_errors/src/emitter.rs:1289:80:
called `Result::unwrap()` on an `Err` value: failed while formatting fluent string `codegen_ssa_unable_to_run_dsymutil`:
the attribute `note` was missing
help: add `.note = <message>`
Indeed there is no note
in the fluent file.
rust/compiler/rustc_codegen_ssa/messages.ftl
Lines 314 to 315 in 3a36386
codegen_ssa_unable_to_run_dsymutil = unable to run `dsymutil`: {$error} | |
while one is expected from the error declaration.
rust/compiler/rustc_codegen_ssa/src/errors.rs
Lines 432 to 434 in 3a36386
#[derive(Diagnostic)] | |
#[diag(codegen_ssa_unable_to_run_dsymutil)] | |
#[note] |
Metadata
Metadata
Assignees
Labels
A-diagnosticsArea: Messages for errors, warnings, and lintsArea: Messages for errors, warnings, and lintsC-bugCategory: This is a bug.Category: This is a bug.I-ICEIssue: The compiler panicked, giving an Internal Compilation Error (ICE) ❄️Issue: The compiler panicked, giving an Internal Compilation Error (ICE) ❄️T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.Relevant to the compiler team, which will review and decide on the PR/issue.