Skip to content

Support format range #111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 18, 2016
Merged

Support format range #111

merged 1 commit into from
Nov 18, 2016

Conversation

agatan
Copy link
Contributor

@agatan agatan commented Oct 1, 2016 •
edited
Loading

rustfmt command supports formatting with specified ranges.
This PR adds RustFmtRange command using the rustfmt --file-lines feature.

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @steveklabnik (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@euclio
Copy link

euclio commented Nov 17, 2016

Any reason this is stalled?

@steveklabnik steveklabnik merged commit 905de98 into rust-lang:master Nov 18, 2016
@steveklabnik
Copy link
Contributor

@euclio just lost in the shuffle. Sorry about that @agatan !

@agatan
Copy link
Contributor Author

agatan commented Dec 2, 2016

Oh, sorry! I missed your comments!
Thank you to see this PR and merge it :)

da-x added a commit that referenced this pull request Oct 13, 2019
@da-x
Only remove undo point if s:RunRustfmt is executed from BufWritePre
8293adc 
Otherwise, we remove unintended undo points.

We can use the already existing parameter to figure out whether we are
executing from BufWritePre context.

Fixes #358. Issue existed since #33c3e214a606, introduced by #111.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@steveklabnik steveklabnik

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@agatan @rust-highfive @euclio @steveklabnik