Fix edition revision ui tests #9640
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
llogiq
reviewed
Oct 13, 2022
Comment on lines
+2
to
+3
| //[edition2018] edition:2018 | ||
| //[edition2021] edition:2021 |
Contributor
There was a problem hiding this comment.
I'm curious: Does this compile the code under both revisions?
Member
Author
There was a problem hiding this comment.
It does yeah, a test is compiled once per revision, the [revision] syntax makes the magic comment thingies only apply on that revision
Contributor
|
Thank you! @bors r+ |
Contributor
Contributor
Contributor
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Contributor
|
Thanks for digging into this! I feel slightly validated that I wasn't going crazy with it :) That said, ideally spacing shouldn't play this much of a role IMO, and perhaps we should get a PR for the upstream to ignore extra spaces? Regardless, thx! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#9605 had me wondering how the edition revision tests were working for
manual_assertbut not for @nyurik, but it turns outmanual_assert's tests weren't working either. I checked howrust-lang/rustdoes it and apparently it comes down to whitespace,//[rev] edition:Xworks 😬Removes the revisions from
match_wild_err_armas I couldn't find any edition dependant behaviour therer? @llogiq
changelog: none