Skip to content

Conversation

xFrednet
Copy link
Contributor

A fix for the suggestion from #8213

changelog: [manual_bits]: The suggestion now includes a cast for proper type conversion

@rust-highfive
Copy link

r? @giraffate

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Apr 10, 2022
@xFrednet xFrednet marked this pull request as draft April 10, 2022 17:08
@xFrednet xFrednet force-pushed the 8213-manual-bits-suggestion branch from fe7da3b to 26acd20 Compare April 10, 2022 17:29
@xFrednet xFrednet marked this pull request as ready for review April 10, 2022 17:30
@xFrednet xFrednet force-pushed the 8213-manual-bits-suggestion branch from 26acd20 to 1613c54 Compare April 10, 2022 17:31
@giraffate
Copy link
Contributor

The test fails in ui/manual_bits.rs, can this be updated?

@xFrednet xFrednet force-pushed the 8213-manual-bits-suggestion branch from 1613c54 to 1b85270 Compare April 13, 2022 17:22
@xFrednet
Copy link
Contributor Author

Thank you for the message, I've missed the failed CI. Now it should be ready, the update only added clippy::useless_conversion to the allowed lint list in the test file :)

@xFrednet xFrednet force-pushed the 8213-manual-bits-suggestion branch from 1b85270 to ba15cdd Compare April 13, 2022 17:31
Copy link
Contributor

@giraffate giraffate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can the example in doc be updated like below?

    /// ### Example
    /// ```rust
    /// std::mem::size_of::<usize>() * 8;
    /// ```
    /// Use instead:
    /// ```rust
    /// usize::BITS as usize;
    /// ```

@giraffate
Copy link
Contributor

@bors r+

Thanks!

@bors
Copy link
Contributor

bors commented Apr 14, 2022

📌 Commit 3bd0ac7 has been approved by giraffate

@bors
Copy link
Contributor

bors commented Apr 14, 2022

⌛ Testing commit 3bd0ac7 with merge ecb3c3f...

@bors
Copy link
Contributor

bors commented Apr 14, 2022

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: giraffate
Pushing ecb3c3f to master...

@bors bors merged commit ecb3c3f into rust-lang:master Apr 14, 2022
@xFrednet xFrednet deleted the 8213-manual-bits-suggestion branch April 14, 2022 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants