check use_self in pat
#8456
Merged
check use_self in pat
#8456
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @llogiq (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
Contributor
|
Thank you! @bors r+ |
Contributor
|
📌 Commit 3d09eb9 has been approved by |
bors
added a commit
that referenced
this pull request
Feb 26, 2022
check `use_self` in `pat` fixes #6955 changelog: check `use_self` in `pat`
Contributor
Contributor
|
💔 Test failed - checks-action_test |
ebobrow
force-pushed
the
use_self_pat
branch
from
3d09eb9 to
914ae1e
Compare
Contributor
Author
|
Looks like a formatting error. I think this should fix it. |
Contributor
|
I think it's because SelfTy is not (or no longer?) a tuple struct. |
Contributor
Author
|
Got it. I changed it in the new code, but should I also fix it where it appears elsewhere in the file? |
Contributor
|
I guess that shouldn't be needed. Let's see. @bors r+ |
Contributor
|
📌 Commit 914ae1e has been approved by |
Contributor
Contributor
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #6955
changelog: check
use_selfinpat