Skip to content

Conversation

Alexendoo
Copy link
Member

changelog: Make dbg_macro work with crate level attributes and inside macro calls

One down for #6610, fixes #7275

Also fixes #7274, and adds parenthesis around the suggestion for dbg!(1, 2, 3) as it expands to a tuple

@rust-highfive
Copy link

r? @Manishearth

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Feb 11, 2022
@flip1995
Copy link
Member

Awesome, thank you! 2 pre-expansion passes to go 🎉

@bors r+

@bors
Copy link
Contributor

bors commented Feb 11, 2022

📌 Commit 41d7c7e has been approved by flip1995

@bors
Copy link
Contributor

bors commented Feb 11, 2022

⌛ Testing commit 41d7c7e with merge 96c73c5...

@bors
Copy link
Contributor

bors commented Feb 11, 2022

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: flip1995
Pushing 96c73c5 to master...

@bors bors merged commit 96c73c5 into rust-lang:master Feb 11, 2022
@Alexendoo Alexendoo deleted the dbg_macro branch February 11, 2022 17:52
@smoelius
Copy link
Contributor

@flip1995

Awesome, thank you! 2 pre-expansion passes to go tada

Is there an effort to eliminate pre-expansion pass lints? Can I ask why?

@giraffate
Copy link
Contributor

Is there an effort to eliminate pre-expansion pass lints? Can I ask why?

FYI: #5518

@smoelius
Copy link
Contributor

Thanks, @giraffate. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dbg_macro not caught when in submodule dbg_macro does not catch invocation inside macro
7 participants