Skip to content

Expands manual_memcpy to lint ones with loop counters #5727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 35 commits into from
Oct 10, 2020
Merged

Expands manual_memcpy to lint ones with loop counters #5727

Show file tree
Hide file tree
Changes from 23 commits
Commits
Show all changes
35 commits
Select commit Hold shift + click to select a range
dc89bb1
Use if_chain in Increment/InitializeVisitor
rail-rain Jun 10, 2020
116f30d
Use else blocks instead of return statements in Increment/InitializeV…
rail-rain Jun 10, 2020
b2d5b89
Check if it's after the loop earlier
rail-rain Jun 10, 2020
31cb110
add concinient methods to Increment/InitializeVisitor
rail-rain Jun 10, 2020
c599e2f
Split VarState
rail-rain Jun 10, 2020
13c207d
Generalise `InitializeVisitor`
rail-rain Jun 10, 2020
9573a0d
Rename variables
rail-rain Jun 10, 2020
1026b42
Rename a struct and variables
rail-rain Jun 10, 2020
b4b4da1
Introduce Start and StartKind
rail-rain Jun 10, 2020
720f19f
Implement detecting `manual_memcpy` with loop counters
rail-rain Jun 10, 2020
de56279
Implement building the `manual_memcpy` sugggestion with loop counters
rail-rain Jun 10, 2020
8da6cfd
fmt
rail-rain Jun 11, 2020
d9a88be
Rename `get_offset` and its private items
rail-rain Jun 17, 2020
774e82a
Add the tests for `manual_memcpy` with loop counters
rail-rain Jun 10, 2020
9aad38b
Update `manual_memcpy.stderr` to reflect additional parentheses
rail-rain Jun 17, 2020
4ea4a97
Add tests for bitwise operations
rail-rain Jun 18, 2020
eb3ffe6
make use of macros in operator overloading
rail-rain Jun 23, 2020
10d7a18
fmt
rail-rain Jun 23, 2020
174065f
fix the multiple counters test
rail-rain Jun 23, 2020
4418738
Use operator overloading instead of direct calls of `make_binop`
rail-rain Jun 24, 2020
f410df3
make clippy happy (`needless_pass_by_value`, `filter_map` and `find_m…
rail-rain Jun 27, 2020
ce653d6
use `#[derive]` instead of the manual implementation
rail-rain Jul 1, 2020
e855fe3
Reflect the changes that has been made and fmt
rail-rain Aug 16, 2020
4918e7a
Replace `snippet_opt` + `unwrap_or_else` with `snippet`
rail-rain Sep 27, 2020
5c71352
Prevent unnecessary lints from triggering
rail-rain Sep 27, 2020
99aceeb
Use the spans of the entire `for` loops for suggestions
rail-rain Sep 27, 2020
9725f00
Use the `From` trait to make `MinifyingSugg`
rail-rain Sep 27, 2020
ec94bd6
split up the `manual_memcpy` test
rail-rain Sep 27, 2020
3883841
document `MinifyingSugg` and `Offset`
rail-rain Oct 2, 2020
94d7b82
simplify the code
rail-rain Oct 2, 2020
1402d8a
fix a FN where incr exprs with no semicolon at ends
rail-rain Oct 2, 2020
41a0ccb
add comments around `loop_counters`
rail-rain Oct 2, 2020
2a0e45b
supress `clippy::filter_map`
rail-rain Oct 2, 2020
7820cb1
Add tests for
rail-rain Oct 2, 2020
b541884
remove the explicit return value of `print_limit`
rail-rain Oct 2, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading