Fix boxed_local suggestion
#3794
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't warn about an argument that is moved into a closure. ExprUseVisitor doesn't walk into nested bodies so use a new visitor that collects the variables that are moved into closures. Fixes #3739
|
This seems like it could be a common issue with other uses of |
Use ExprUseVisitor correctly instead.
|
I was wrong about |
flip1995
added
the
S-waiting-on-review
|
☔ The latest upstream changes (presumably #3767) made this pull request unmergeable. Please resolve the merge conflicts. |
|
@bors r+ |
|
📌 Commit 6937d55 has been approved by |
bors
added a commit
that referenced
this pull request
Mar 12, 2019
Fix `boxed_local` suggestion Don't warn about an argument that is moved into a closure. ExprUseVisitor doesn't walk into nested bodies so use a new visitor that collects the variables that are moved into closures. Fixes #3739
|
☀️ Test successful - checks-travis, status-appveyor |
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't warn about an argument that is moved into a closure.
ExprUseVisitor doesn't walk into nested bodies so use a new
visitor that collects the variables that are moved into closures.
Fixes #3739