Do not attempt to compute size of a type with escaping lifetimes #15434
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samueltardieu
added
the
I-ICE
rustbot
added
the
S-waiting-on-review
|
@rustbot note Beta nomination The bug is a regression from stable to stable in Clippy 1.89. The fix should be applied to 1.90, and probably to 1.89.1 if there is a point release. The fix is safe as it makes the lint triggers in less cases. The only risk, and it is unlikely, would be the creation of false negatives which would be benign. Cc @flip1995 |
rustbot
added
the
beta-nominated
A type with escaping bound vars cannot be wrapped in a dummy binder during size computation.
samueltardieu
force-pushed
the
issue-15429
branch
from
229929e to
c752fb2
Compare
|
Force-pushed to update comment with a more precise one. |
rustbot
removed
the
S-waiting-on-review
flip1995
added
beta-accepted
bors
pushed a commit
to rust-lang/rust
that referenced
this pull request
Sep 11, 2025
) A type with escaping bound vars cannot be wrapped in a dummy binder during size computation. Fixes rust-lang/rust-clippy#15429 changelog: [`zero_sized_hashmap_values`]: fix ICE in types with escaping lifetimes r? Jarcho <!-- TRIAGEBOT_START --> <!-- TRIAGEBOT_SUMMARY_START --> ### Summary Notes - [Beta nomination](rust-lang/rust-clippy#15434 (comment)) by [samueltardieu](https://github.com/samueltardieu) *Managed by `@rustbot`—see [help](https://forge.rust-lang.org/triagebot/note.html) for details* <!-- TRIAGEBOT_SUMMARY_END --> <!-- TRIAGEBOT_END -->
bors
added a commit
to rust-lang/rust
that referenced
this pull request
Sep 11, 2025
[beta] Clippy backport Only a single commit to backport: - rust-lang/rust-clippy#15434 We'd like to get this ICE fix in a release earlier. r? Mark-Simulacrum
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A type with escaping bound vars cannot be wrapped in a dummy binder during size computation.
Fixes #15429
changelog: [
zero_sized_hashmap_values]: fix ICE in types with escaping lifetimesr? Jarcho
Summary Notes
Managed by
@rustbot—see help for details